[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/7] migration: Rename vmstate_info_nullptr
From: |
Peter Xu |
Subject: |
Re: [PATCH v3 4/7] migration: Rename vmstate_info_nullptr |
Date: |
Thu, 9 Jan 2025 14:10:04 -0500 |
On Thu, Jan 09, 2025 at 03:52:46PM -0300, Fabiano Rosas wrote:
> Rename vmstate_info_nullptr from "uint64_t" to "nullptr". This vmstate
> actually reads and writes just a byte, so the proper name would be
> uint8. However, since this is a marker for a NULL pointer, it's
> convenient to have a more explicit name that can be identified by the
> consumers of the JSON part of the stream.
>
> Change the name to "nullptr" and add support for it in the
> analyze-migration.py script. Arbitrarily use the name of the type as
> the value of the field to avoid the script showing 0x30 or '0', which
> could be confusing for readers.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- [PATCH v3 0/7] migration: Fix s390 regressions + migration script, Fabiano Rosas, 2025/01/09
- [PATCH v3 3/7] migration: Fix parsing of s390 stream, Fabiano Rosas, 2025/01/09
- [PATCH v3 1/7] migration: Add more error handling to analyze-migration.py, Fabiano Rosas, 2025/01/09
- [PATCH v3 4/7] migration: Rename vmstate_info_nullptr, Fabiano Rosas, 2025/01/09
- Re: [PATCH v3 4/7] migration: Rename vmstate_info_nullptr,
Peter Xu <=
- [PATCH v3 6/7] migration: Fix arrays of pointers in JSON writer, Fabiano Rosas, 2025/01/09
- [PATCH v3 7/7] s390x: Fix CSS migration, Fabiano Rosas, 2025/01/09
- [PATCH v3 5/7] migration: Dump correct JSON format for nullptr replacement, Fabiano Rosas, 2025/01/09
- [PATCH v3 2/7] migration: Remove unused argument in vmsd_desc_field_end, Fabiano Rosas, 2025/01/09