Re: [PATCH 0/9] ppc/pnv: HOMER and OCC fixes and improvements

[Cédric Le Goater]

Hello,

On 12/10/24 04:04, Nicholas Piggin wrote:
> This series makes a bunch of fixes and improvements to the HOMER and
> OCC unit models for powernv. It gets OPAL OCC code happier again,

Nice. I had similar changes exposing pstates and sensors for QEMU.
I am glad this is now possible.

> but requires this series of skiboot fixes (which I will hope to get
> upstream and then into QEMU in the same release as this series is
> merged.
>
> https://lists.ozlabs.org/pipermail/skiboot/2024-November/019013.html
>
> Big changes is moving HOMER from mmio register implementation to a
> RAM memory region which better maches hardware and is much easier to
> work with; and the addition of some dynamic OCC behaviour to the
> device model.
>
> I wouldn't expect any review of OCC details. It's neglected and this
> series gets it in better shape than before. But anything on the
> basic structure and QEMU details is welcome. I will add some test
> cases to help ensure it doesn't regress in future, I will have to
> juggle the skiboot fixes as well though, so will do that later.

Have you considered modeling the OCC in QEMU ? I am asking because
I have a series removing all 405 support in QEMU 10.0.

Thanks,

C.



> Thanks,
> Nick
>
> Nicholas Piggin (9):
>    ppc/pnv/homer: Fix OCC registers
>    ppc/pnv/homer: Make dummy reads return 0
>    ppc/pnv/occ: Fix common area sensor offsets
>    ppc/pnv/homer: class-based base and size
>    ppc/pnv/occ: Better document OCCMISC bits
>    ppc/pnv: Make HOMER memory a RAM region
>    ppc/pnv/occ: Update pstate frequency tables
>    ppc/pnv/occ: Add POWER10 OCC-OPAL data format
>    ppc/pnv/occ: Implement a basic dynamic OCC model
>
>   include/hw/ppc/pnv.h       |   6 +-
>   include/hw/ppc/pnv_homer.h |  12 +-
>   include/hw/ppc/pnv_occ.h   |   9 +
>   hw/ppc/pnv.c               |  87 +++--
>   hw/ppc/pnv_homer.c         | 230 +++----------
>   hw/ppc/pnv_occ.c           | 668 +++++++++++++++++++++++++++++++++++--
>   6 files changed, 742 insertions(+), 270 deletions(-)