[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 26/71] hw/gpio: Constify all Property
From: |
Miles Glenn |
Subject: |
Re: [PATCH 26/71] hw/gpio: Constify all Property |
Date: |
Mon, 06 Jan 2025 14:15:06 -0600 |
Reviewed-by: Glenn Miles <milesg@linux.ibm.com>
On Fri, 2024-12-13 at 13:07 -0600, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> hw/gpio/imx_gpio.c | 2 +-
> hw/gpio/npcm7xx_gpio.c | 2 +-
> hw/gpio/omap_gpio.c | 2 +-
> hw/gpio/pca9552.c | 2 +-
> hw/gpio/pca9554.c | 2 +-
> hw/gpio/pl061.c | 2 +-
> hw/gpio/sifive_gpio.c | 2 +-
> hw/gpio/stm32l4x5_gpio.c | 2 +-
> 8 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gpio.c
> index 27535a577f..919d53701f 100644
> --- a/hw/gpio/imx_gpio.c
> +++ b/hw/gpio/imx_gpio.c
> @@ -290,7 +290,7 @@ static const VMStateDescription vmstate_imx_gpio
> = {
> }
> };
>
> -static Property imx_gpio_properties[] = {
> +static const Property imx_gpio_properties[] = {
> DEFINE_PROP_BOOL("has-edge-sel", IMXGPIOState, has_edge_sel,
> true),
> DEFINE_PROP_BOOL("has-upper-pin-irq", IMXGPIOState,
> has_upper_pin_irq,
> false),
> diff --git a/hw/gpio/npcm7xx_gpio.c b/hw/gpio/npcm7xx_gpio.c
> index ba19b9ebad..db6792b2ad 100644
> --- a/hw/gpio/npcm7xx_gpio.c
> +++ b/hw/gpio/npcm7xx_gpio.c
> @@ -386,7 +386,7 @@ static const VMStateDescription
> vmstate_npcm7xx_gpio = {
> },
> };
>
> -static Property npcm7xx_gpio_properties[] = {
> +static const Property npcm7xx_gpio_properties[] = {
> /* Bit n set => pin n has pullup enabled by default. */
> DEFINE_PROP_UINT32("reset-pullup", NPCM7xxGPIOState, reset_pu,
> 0),
> /* Bit n set => pin n has pulldown enabled by default. */
> diff --git a/hw/gpio/omap_gpio.c b/hw/gpio/omap_gpio.c
> index a47a2167a6..03ee9e47c6 100644
> --- a/hw/gpio/omap_gpio.c
> +++ b/hw/gpio/omap_gpio.c
> @@ -225,7 +225,7 @@ void omap_gpio_set_clk(Omap1GpioState *gpio,
> omap_clk clk)
> gpio->clk = clk;
> }
>
> -static Property omap_gpio_properties[] = {
> +static const Property omap_gpio_properties[] = {
> DEFINE_PROP_INT32("mpu_model", Omap1GpioState, mpu_model, 0),
> DEFINE_PROP_END_OF_LIST(),
> };
> diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c
> index 59b233339a..427419d218 100644
> --- a/hw/gpio/pca9552.c
> +++ b/hw/gpio/pca9552.c
> @@ -428,7 +428,7 @@ static void pca955x_realize(DeviceState *dev,
> Error **errp)
> qdev_init_gpio_in(dev, pca955x_gpio_in_handler, k->pin_count);
> }
>
> -static Property pca955x_properties[] = {
> +static const Property pca955x_properties[] = {
> DEFINE_PROP_STRING("description", PCA955xState, description),
> DEFINE_PROP_END_OF_LIST(),
> };
> diff --git a/hw/gpio/pca9554.c b/hw/gpio/pca9554.c
> index 68cc9e1de4..e8b0458aac 100644
> --- a/hw/gpio/pca9554.c
> +++ b/hw/gpio/pca9554.c
> @@ -291,7 +291,7 @@ static void pca9554_realize(DeviceState *dev,
> Error **errp)
> qdev_init_gpio_in(dev, pca9554_gpio_in_handler,
> PCA9554_PIN_COUNT);
> }
>
> -static Property pca9554_properties[] = {
> +static const Property pca9554_properties[] = {
> DEFINE_PROP_STRING("description", PCA9554State, description),
> DEFINE_PROP_END_OF_LIST(),
> };
> diff --git a/hw/gpio/pl061.c b/hw/gpio/pl061.c
> index d5838b8e98..9b8ca6de32 100644
> --- a/hw/gpio/pl061.c
> +++ b/hw/gpio/pl061.c
> @@ -562,7 +562,7 @@ static void pl061_realize(DeviceState *dev, Error
> **errp)
> }
> }
>
> -static Property pl061_props[] = {
> +static const Property pl061_props[] = {
> DEFINE_PROP_UINT32("pullups", PL061State, pullups, 0xff),
> DEFINE_PROP_UINT32("pulldowns", PL061State, pulldowns, 0x0),
> DEFINE_PROP_END_OF_LIST()
> diff --git a/hw/gpio/sifive_gpio.c b/hw/gpio/sifive_gpio.c
> index e85c0406a2..5603f0c235 100644
> --- a/hw/gpio/sifive_gpio.c
> +++ b/hw/gpio/sifive_gpio.c
> @@ -349,7 +349,7 @@ static const VMStateDescription
> vmstate_sifive_gpio = {
> }
> };
>
> -static Property sifive_gpio_properties[] = {
> +static const Property sifive_gpio_properties[] = {
> DEFINE_PROP_UINT32("ngpio", SIFIVEGPIOState, ngpio,
> SIFIVE_GPIO_PINS),
> DEFINE_PROP_END_OF_LIST(),
> };
> diff --git a/hw/gpio/stm32l4x5_gpio.c b/hw/gpio/stm32l4x5_gpio.c
> index 30d8d6cba4..d1394f3f55 100644
> --- a/hw/gpio/stm32l4x5_gpio.c
> +++ b/hw/gpio/stm32l4x5_gpio.c
> @@ -447,7 +447,7 @@ static const VMStateDescription
> vmstate_stm32l4x5_gpio = {
> }
> };
>
> -static Property stm32l4x5_gpio_properties[] = {
> +static const Property stm32l4x5_gpio_properties[] = {
> DEFINE_PROP_STRING("name", Stm32l4x5GpioState, name),
> DEFINE_PROP_UINT32("mode-reset", Stm32l4x5GpioState,
> moder_reset, 0),
> DEFINE_PROP_UINT32("ospeed-reset", Stm32l4x5GpioState,
> ospeedr_reset, 0),
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 26/71] hw/gpio: Constify all Property,
Miles Glenn <=