[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 42/44] scripts/checkpatch.pl: emit error when using assert(false)
From: |
Thomas Huth |
Subject: |
[PULL 42/44] scripts/checkpatch.pl: emit error when using assert(false) |
Date: |
Wed, 25 Sep 2024 13:10:23 +0200 |
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-ID: <20240919044641.386068-35-pierrick.bouvier@linaro.org>
[thuth: Split long line to avoid checkpatch error]
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
scripts/checkpatch.pl | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 65b6f46f90..1b21249c91 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3102,6 +3102,10 @@ sub process {
if ($line =~ /\b(g_)?assert\(0\)/) {
ERROR("use g_assert_not_reached() instead of
assert(0)\n" . $herecurr);
}
+ if ($line =~ /\b(g_)?assert\(false\)/) {
+ ERROR("use g_assert_not_reached() instead of
assert(false)\n" .
+ $herecurr);
+ }
if ($line =~ /\bstrerrorname_np\(/) {
ERROR("use strerror() instead of strerrorname_np()\n" .
$herecurr);
}
--
2.46.0
- [PULL 35/44] hw/net: remove return after g_assert_not_reached(), (continued)
- [PULL 35/44] hw/net: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 37/44] hw/ppc: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 44/44] .gitlab-ci.d: Make separate collapsible log sections for build and test, Thomas Huth, 2024/09/25
- [PULL 40/44] qom: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 39/44] qobject: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 31/44] fpu: remove break after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 36/44] hw/pci: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 38/44] migration: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 32/44] tcg/loongarch64: remove break after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 41/44] tests/qtest: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 42/44] scripts/checkpatch.pl: emit error when using assert(false),
Thomas Huth <=
- [PULL 43/44] .gitlab-ci.d: Split build and test in cross build job templates, Thomas Huth, 2024/09/25
- Re: [PULL 00/44] Functional test conversion, and assert(0) cleanup, Pierrick Bouvier, 2024/09/25
- Re: [PULL 00/44] Functional test conversion, and assert(0) cleanup, Peter Maydell, 2024/09/28