qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PULL 42/44] scripts/checkpatch.pl: emit error when using assert(false)


From: Thomas Huth
Subject: [PULL 42/44] scripts/checkpatch.pl: emit error when using assert(false)
Date: Wed, 25 Sep 2024 13:10:23 +0200

From: Pierrick Bouvier <pierrick.bouvier@linaro.org>

This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-ID: <20240919044641.386068-35-pierrick.bouvier@linaro.org>
[thuth: Split long line to avoid checkpatch error]
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 scripts/checkpatch.pl | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 65b6f46f90..1b21249c91 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3102,6 +3102,10 @@ sub process {
                if ($line =~ /\b(g_)?assert\(0\)/) {
                        ERROR("use g_assert_not_reached() instead of 
assert(0)\n" . $herecurr);
                }
+               if ($line =~ /\b(g_)?assert\(false\)/) {
+                       ERROR("use g_assert_not_reached() instead of 
assert(false)\n" .
+                             $herecurr);
+               }
                if ($line =~ /\bstrerrorname_np\(/) {
                        ERROR("use strerror() instead of strerrorname_np()\n" . 
$herecurr);
                }
-- 
2.46.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]