[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 38/44] migration: remove return after g_assert_not_reached()
From: |
Thomas Huth |
Subject: |
[PULL 38/44] migration: remove return after g_assert_not_reached() |
Date: |
Wed, 25 Sep 2024 13:10:19 +0200 |
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20240919044641.386068-31-pierrick.bouvier@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
migration/dirtyrate.c | 1 -
migration/postcopy-ram.c | 7 -------
migration/ram.c | 2 --
3 files changed, 10 deletions(-)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index c03b13b624..5478d58de3 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -229,7 +229,6 @@ static int time_unit_to_power(TimeUnit time_unit)
return -3;
default:
g_assert_not_reached();
- return 0;
}
}
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index f431bbc0d4..0fe9d83d44 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -1412,40 +1412,34 @@ int postcopy_ram_incoming_init(MigrationIncomingState
*mis)
int postcopy_ram_incoming_cleanup(MigrationIncomingState *mis)
{
g_assert_not_reached();
- return -1;
}
int postcopy_ram_prepare_discard(MigrationIncomingState *mis)
{
g_assert_not_reached();
- return -1;
}
int postcopy_request_shared_page(struct PostCopyFD *pcfd, RAMBlock *rb,
uint64_t client_addr, uint64_t rb_offset)
{
g_assert_not_reached();
- return -1;
}
int postcopy_ram_incoming_setup(MigrationIncomingState *mis)
{
g_assert_not_reached();
- return -1;
}
int postcopy_place_page(MigrationIncomingState *mis, void *host, void *from,
RAMBlock *rb)
{
g_assert_not_reached();
- return -1;
}
int postcopy_place_page_zero(MigrationIncomingState *mis, void *host,
RAMBlock *rb)
{
g_assert_not_reached();
- return -1;
}
int postcopy_wake_shared(struct PostCopyFD *pcfd,
@@ -1453,7 +1447,6 @@ int postcopy_wake_shared(struct PostCopyFD *pcfd,
RAMBlock *rb)
{
g_assert_not_reached();
- return -1;
}
#endif
diff --git a/migration/ram.c b/migration/ram.c
index 0aa5d34743..81eda2736a 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1766,13 +1766,11 @@ bool ram_write_tracking_available(void)
bool ram_write_tracking_compatible(void)
{
g_assert_not_reached();
- return false;
}
int ram_write_tracking_start(void)
{
g_assert_not_reached();
- return -1;
}
void ram_write_tracking_stop(void)
--
2.46.0
- [PULL 33/44] include/qemu: remove return after g_assert_not_reached(), (continued)
- [PULL 33/44] include/qemu: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 30/44] target/riscv: remove break after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 34/44] hw/hyperv: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 35/44] hw/net: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 37/44] hw/ppc: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 44/44] .gitlab-ci.d: Make separate collapsible log sections for build and test, Thomas Huth, 2024/09/25
- [PULL 40/44] qom: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 39/44] qobject: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 31/44] fpu: remove break after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 36/44] hw/pci: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 38/44] migration: remove return after g_assert_not_reached(),
Thomas Huth <=
- [PULL 32/44] tcg/loongarch64: remove break after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 41/44] tests/qtest: remove return after g_assert_not_reached(), Thomas Huth, 2024/09/25
- [PULL 42/44] scripts/checkpatch.pl: emit error when using assert(false), Thomas Huth, 2024/09/25
- [PULL 43/44] .gitlab-ci.d: Split build and test in cross build job templates, Thomas Huth, 2024/09/25
- Re: [PULL 00/44] Functional test conversion, and assert(0) cleanup, Pierrick Bouvier, 2024/09/25
- Re: [PULL 00/44] Functional test conversion, and assert(0) cleanup, Peter Maydell, 2024/09/28