[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add 'info pg' command to monitor
From: |
Nadav Amit |
Subject: |
Re: Add 'info pg' command to monitor |
Date: |
Wed, 17 Apr 2024 11:30:32 +0300 |
> On 16 Apr 2024, at 21:11, Don Porter <porter@cs.unc.edu> wrote:
>
> On 4/16/24 13:03, Peter Maydell wrote:
>> On Tue, 16 Apr 2024 at 17:53, Don Porter <porter@cs.unc.edu> wrote:
>>> There is still a lot I am learning about the code base, but it seems
>>> that qemu_get_guest_memory_mapping() does most of what one would need.
>>> It currently only returns the "leaves" of the page table tree in a list.
>>>
>>> What if I extend this function with an optional argument to either
>>> 1) return the interior nodes of the page table in additional lists (and
>>> then parse+print in the monitor code), or
>>> 2) inline the monitor printing in the arch-specific hook, and pass a
>>> flag to get_guest_memory_mapping() that turns on/off the statements that
>>> pretty print the page tables?
>>>
>>> It looks like most CPUs implement this function as part of checkpointing.
>> As far as I can see only x86 implements the get_memory_mapping
>> function, so once again somebody has added some bit of
>> functionality that does a walk of the page tables that is
>> x86 only and that shares no code with any of the other
>> page table walking code :-(
>
> My mistake - get_memory_mappings() is only implemented in x86.
>
Hi Don,
Your email popped up, so I just drop my 2 cents.
If you are only interested in x86, you can just build a gdb script that would
parse the page tables and present the data. It might be less efficient, but
easier to maintain.
Regards,
Nadav
- Add 'info pg' command to monitor, Don Porter, 2024/04/15
- [PATCH 1/2] monitor: Implement a generic x86 page table iterator, Don Porter, 2024/04/15
- [PATCH 2/2] monitor: Add an "info pg" command that prints the current page tables, Don Porter, 2024/04/15
- Re: Add 'info pg' command to monitor, Peter Maydell, 2024/04/15
- Re: Add 'info pg' command to monitor, Peter Maydell, 2024/04/19
- Re: Add 'info pg' command to monitor, Dr. David Alan Gilbert, 2024/04/19