qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-9.0? v2 4/4] meson: Enable -Wstatic-in-inline


From: Paolo Bonzini
Subject: Re: [PATCH-for-9.0? v2 4/4] meson: Enable -Wstatic-in-inline
Date: Wed, 27 Mar 2024 15:12:40 +0100



Il mer 27 mar 2024, 13:42 Philippe Mathieu-Daudé <philmd@linaro.org> ha scritto:
IIUC your comment, you are worried about system headers declaring
non-static inline functions?

No, it's just that the flag (and thus the patch) is not doing what the commit message says.

Perhaps you could instead add a checkpatch test that catches occurrences of inline without static.

Paolo


>
> For now I'm queuing patches 1-3 only.
>
> Paolo
>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Message-Id: <20240313184954.42513-5-philmd@linaro.org" target="_blank" rel="noreferrer">20240313184954.42513-5-philmd@linaro.org>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   meson.build | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meson.build b/meson.build
>> index c9c3217ba4..f400f7d36c 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -591,6 +591,7 @@ warn_flags = [
>>     '-Wold-style-definition',
>>     '-Wredundant-decls',
>>     '-Wshadow=local',
>> +  '-Wstatic-in-inline',
>>     '-Wstrict-prototypes',
>>     '-Wtype-limits',
>>     '-Wundef',
>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]