Re: [PATCH-for-9.0? v2 4/4] meson: Enable -Wstatic-in-inline

[Thomas Huth]

On 26/03/2024 18.10, Philippe Mathieu-Daudé wrote:
> Compilers are clever enough to inline code when necessary.
>
> The only case we accept an inline function is static in
> header (we use C, not C++).
>
> Add the -Wstatic-in-inline CPPFLAG to prevent public and

I think this is rather a compiler than a pre-processor flag, so 
s/CPPFLAG/CFLAGS/ ?

Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>


> inline function to be added in the code base.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Message-Id: <20240313184954.42513-5-philmd@linaro.org>
> ---
>   meson.build | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/meson.build b/meson.build
> index c9c3217ba4..f400f7d36c 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -591,6 +591,7 @@ warn_flags = [
>     '-Wold-style-definition',
>     '-Wredundant-decls',
>     '-Wshadow=local',
> +  '-Wstatic-in-inline',
>     '-Wstrict-prototypes',
>     '-Wtype-limits',
>     '-Wundef',