Re: [PATCH v6 10/11] virtio-gpu: Initialize Venus

[Pierre-Eric Pelloux-Prayer]

Le 23/02/2024 à 10:15, Huang Rui a écrit :
> On Tue, Jan 02, 2024 at 09:33:11PM +0800, Marc-André Lureau wrote:
> > Hi
> >
> > On Tue, Dec 19, 2023 at 11:55 AM Huang Rui <ray.huang@amd.com> wrote:
> > > From: Antonio Caggiano <antonio.caggiano@collabora.com>
> > >
> > > Request Venus when initializing VirGL.
> > >
> > > Signed-off-by: Antonio Caggiano <antonio.caggiano@collabora.com>
> > > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > > ---
> > >
> > > Changes in v6:
> > > - Remove the unstable API flags check because virglrenderer is already 1.0.
> > > - Squash the render server flag support into "Initialize Venus".
> > >
> > >   hw/display/virtio-gpu-virgl.c | 4 ++++
> > >   1 file changed, 4 insertions(+)
> > >
> > > diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c
> > > index f35a751824..c523a6717a 100644
> > > --- a/hw/display/virtio-gpu-virgl.c
> > > +++ b/hw/display/virtio-gpu-virgl.c
> > > @@ -964,6 +964,10 @@ int virtio_gpu_virgl_init(VirtIOGPU *g)
> > >       }
> > >   #endif
> > >
> > > +#ifdef VIRGL_RENDERER_VENUS
> > > +    flags |= VIRGL_RENDERER_VENUS | VIRGL_RENDERER_RENDER_SERVER;
> > > +#endif
> > > +
> >
> > I wonder if it's a good idea to initialize venus by default. It
> > doesn't seem to require vulkan during initialization, but this may
> > evolve. Make it optional?
>
> I am fine. In fact, vulkan is widely used for graphic area such as gaming,
> compute, VR/AR, etc.

Actually, making it optional is useful because Venus support is optional in
virglrenderer (= having VIRGL_RENDERER_VENUS defined doesn't mean that
Venus is supported).

Thanks,
Pierre-Eric


> Thanks,
> Ray
>
> > >       ret = virgl_renderer_init(g, flags, &virtio_gpu_3d_cbs);
> > >       if (ret != 0) {
> > >           error_report("virgl could not be initialized: %d", ret);
> > > --
> > > 2.25.1
> >
> >
> > --
> > Marc-André Lureau