[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] qapi: document parameters of query-cpu-model-* QAPI comma
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v1] qapi: document parameters of query-cpu-model-* QAPI commands |
Date: |
Mon, 25 Mar 2024 18:43:08 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
David Hildenbrand <david@redhat.com> writes:
>>> #
>>> # Usually, a CPU model is compared against the maximum possible CPU
>>> # model of a certain configuration (e.g. the "host" model for KVM).
>>> @@ -154,7 +155,14 @@
>>> # Some architectures may not support comparing CPU models. s390x
>>> # supports comparing CPU models.
>>> #
>>> -# Returns: a CpuModelBaselineInfo
>>> +# @modela: description of the first CPU model to compare, referred to as
>>> +# "model A" in CpuModelCompareResult
>>> +#
>>> +# @modelb: description of the second CPU model to compare, referred to as
>>> +# "model B" in CpuModelCompareResult
>>> +#
>>> +# Returns: a CpuModelCompareInfo, describing how both CPU models
>>
>> Scratch the comma?
>
> Agreed to both. Do you want to fixup when applying or do you prefer a v2?
Happy to fix it up myself, thanks!
> Thanks!
>
>> Reviewed-by: Markus Armbruster <armbru@redhat.com>