qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] qapi: document parameters of query-cpu-model-* QAPI comma


From: David Hildenbrand
Subject: Re: [PATCH v1] qapi: document parameters of query-cpu-model-* QAPI commands
Date: Mon, 25 Mar 2024 17:27:28 +0100
User-agent: Mozilla Thunderbird

  #
  # Usually, a CPU model is compared against the maximum possible CPU
  # model of a certain configuration (e.g. the "host" model for KVM).
@@ -154,7 +155,14 @@
  # Some architectures may not support comparing CPU models.  s390x
  # supports comparing CPU models.
  #
-# Returns: a CpuModelBaselineInfo
+# @modela: description of the first CPU model to compare, referred to as
+#     "model A" in CpuModelCompareResult
+#
+# @modelb: description of the second CPU model to compare, referred to as
+#     "model B" in CpuModelCompareResult
+#
+# Returns: a CpuModelCompareInfo, describing how both CPU models

Scratch the comma?

Agreed to both. Do you want to fixup when applying or do you prefer a v2?

Thanks!


Reviewed-by: Markus Armbruster <armbru@redhat.com>


--
Cheers,

David / dhildenb




reply via email to

[Prev in Thread] Current Thread [Next in Thread]