RE: [PATCH v5 3/7] configure: add --enable-qpl build option

[Liu, Yuan1]

> -----Original Message-----
> From: Thomas Huth <thuth@redhat.com>
> Sent: Wednesday, March 20, 2024 4:57 PM
> To: Liu, Yuan1 <yuan1.liu@intel.com>; peterx@redhat.com; farosas@suse.de
> Cc: qemu-devel@nongnu.org; hao.xiang@bytedance.com;
> bryan.zhang@bytedance.com; Zou, Nanhai <nanhai.zou@intel.com>
> Subject: Re: [PATCH v5 3/7] configure: add --enable-qpl build option
> 
> On 20/03/2024 09.55, Thomas Huth wrote:
> > On 19/03/2024 17.45, Yuan Liu wrote:
> >> add --enable-qpl and --disable-qpl options to enable and disable
> >> the QPL compression method for multifd migration.
> >>
> >> the Query Processing Library (QPL) is an open-source library
> >> that supports data compression and decompression features.
> >>
> >> The QPL compression is based on the deflate compression algorithm
> >> and use Intel In-Memory Analytics Accelerator(IAA) hardware for
> >> compression and decompression acceleration.
> >>
> >> Please refer to the following for more information about QPL
> >>
> https://intel.github.io/qpl/documentation/introduction_docs/introduction.h
> tml
> >>
> >> Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
> >> Reviewed-by: Nanhai Zou <nanhai.zou@intel.com>
> >> ---
> >>   meson.build                   | 16 ++++++++++++++++
> >>   meson_options.txt             |  2 ++
> >>   scripts/meson-buildoptions.sh |  3 +++
> >>   3 files changed, 21 insertions(+)
> >>
> >> diff --git a/meson.build b/meson.build
> >> index b375248a76..bee7dcd53b 100644
> >> --- a/meson.build
> >> +++ b/meson.build
> >> @@ -1200,6 +1200,20 @@ if not get_option('zstd').auto() or have_block
> >>                       required: get_option('zstd'),
> >>                       method: 'pkg-config')
> >>   endif
> >> +qpl = not_found
> >> +if not get_option('qpl').auto()
> >
> > Do you really only want to enable this if the user explicitly specified
> > "--enable-qpl" ? Otherwise, I think this should be:
> >
> >   if not get_option('qpl').auto() or have_system
> >
> > ?
> >
> >   Thomas
> >
> >
> >
> >
> >> +  libqpl = cc.find_library('qpl', required: false)
> 
> ... and it should use "required: get_option('qpl')" in that case.
> 
>   Thomas

Hi Thomas

Thanks for your comments, you are right, I need to add have_system
and check get_option('qpl') here, I will fix this next version.

> >> +  if not libqpl.found()
> >> +    error('libqpl not found, please install it from ' +
> >> +
> >>
> 'https://intel.github.io/qpl/documentation/get_started_docs/installation.h
> tml')
> >> +  endif
> >> +  libaccel = dependency('libaccel-config', version: '>=4.0.0',
> >> +                        required: true,
> >> +                        method: 'pkg-config')
> >> +  qpl = declare_dependency(dependencies: [libqpl, libaccel,
> >> +        cc.find_library('dl', required: get_option('qpl'))],
> >> +        link_args: ['-lstdc++'])
> >> +endif
> >>   virgl = not_found
> >