qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 3/7] configure: add --enable-qpl build option


From: Thomas Huth
Subject: Re: [PATCH v5 3/7] configure: add --enable-qpl build option
Date: Wed, 20 Mar 2024 09:55:10 +0100
User-agent: Mozilla Thunderbird

On 19/03/2024 17.45, Yuan Liu wrote:
add --enable-qpl and --disable-qpl options to enable and disable
the QPL compression method for multifd migration.

the Query Processing Library (QPL) is an open-source library
that supports data compression and decompression features.

The QPL compression is based on the deflate compression algorithm
and use Intel In-Memory Analytics Accelerator(IAA) hardware for
compression and decompression acceleration.

Please refer to the following for more information about QPL
https://intel.github.io/qpl/documentation/introduction_docs/introduction.html

Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
Reviewed-by: Nanhai Zou <nanhai.zou@intel.com>
---
  meson.build                   | 16 ++++++++++++++++
  meson_options.txt             |  2 ++
  scripts/meson-buildoptions.sh |  3 +++
  3 files changed, 21 insertions(+)

diff --git a/meson.build b/meson.build
index b375248a76..bee7dcd53b 100644
--- a/meson.build
+++ b/meson.build
@@ -1200,6 +1200,20 @@ if not get_option('zstd').auto() or have_block
                      required: get_option('zstd'),
                      method: 'pkg-config')
  endif
+qpl = not_found
+if not get_option('qpl').auto()

Do you really only want to enable this if the user explicitly specified "--enable-qpl" ? Otherwise, I think this should be:

 if not get_option('qpl').auto() or have_system

?

 Thomas




+  libqpl = cc.find_library('qpl', required: false)
+  if not libqpl.found()
+    error('libqpl not found, please install it from ' +
+    
'https://intel.github.io/qpl/documentation/get_started_docs/installation.html')
+  endif
+  libaccel = dependency('libaccel-config', version: '>=4.0.0',
+                        required: true,
+                        method: 'pkg-config')
+  qpl = declare_dependency(dependencies: [libqpl, libaccel,
+        cc.find_library('dl', required: get_option('qpl'))],
+        link_args: ['-lstdc++'])
+endif
  virgl = not_found




reply via email to

[Prev in Thread] Current Thread [Next in Thread]