Re: [PATCH v5 12/24] savevm: Fix load_snapshot error path crash

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 12/24] savevm: Fix load_snapshot error path crash

From:	Alex Bennée
Subject:	Re: [PATCH v5 12/24] savevm: Fix load_snapshot error path crash
Date:	Tue, 19 Mar 2024 20:49:14 +0000
User-agent:	mu4e 1.12.2; emacs 29.2

Nicholas Piggin <npiggin@gmail.com> writes:

> An error path missed setting *errp, which can cause a NULL deref.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v5 07/24] chardev: set record/replay on the base device of a muxed device, (continued)
- [PATCH v5 07/24] chardev: set record/replay on the base device of a muxed device, Nicholas Piggin, 2024/03/18
  - Re: [PATCH v5 07/24] chardev: set record/replay on the base device of a muxed device, Alex Bennée, 2024/03/19
- [PATCH v5 08/24] replay: Fix migration use of clock, Nicholas Piggin, 2024/03/18
  - Re: [PATCH v5 08/24] replay: Fix migration use of clock, Alex Bennée, 2024/03/19
    - Re: [PATCH v5 08/24] replay: Fix migration use of clock, Nicholas Piggin, 2024/03/20
- [PATCH v5 10/24] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state, Nicholas Piggin, 2024/03/18
  - Re: [PATCH v5 10/24] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state, Alex Bennée, 2024/03/19
- [PATCH v5 09/24] replay: Fix migration replay_mutex locking, Nicholas Piggin, 2024/03/18
- [PATCH v5 11/24] virtio-net: Use virtual time for RSC timers, Nicholas Piggin, 2024/03/18
- [PATCH v5 12/24] savevm: Fix load_snapshot error path crash, Nicholas Piggin, 2024/03/18
  - Re: [PATCH v5 12/24] savevm: Fix load_snapshot error path crash, Alex Bennée <=
- [PATCH v5 13/24] tests/avocado: replay_linux.py remove the timeout expected guards, Nicholas Piggin, 2024/03/18
  - Re: [PATCH v5 13/24] tests/avocado: replay_linux.py remove the timeout expected guards, Alex Bennée, 2024/03/19
    - Re: [PATCH v5 13/24] tests/avocado: replay_linux.py remove the timeout expected guards, Nicholas Piggin, 2024/03/20
- [PATCH v5 15/24] tests/avocado: reverse_debugging.py add test for x86-64 q35 machine, Nicholas Piggin, 2024/03/18
  - Re: [PATCH v5 15/24] tests/avocado: reverse_debugging.py add test for x86-64 q35 machine, Alex Bennée, 2024/03/19
- [PATCH v5 16/24] tests/avocado: reverse_debugging.py verify addresses between record and replay, Nicholas Piggin, 2024/03/18
- [PATCH v5 17/24] tests/avocado: reverse_debugging.py stop VM before sampling icount, Nicholas Piggin, 2024/03/18
- [PATCH v5 14/24] tests/avocado: reverse_debugging.py mark aarch64 and pseries as not flaky, Nicholas Piggin, 2024/03/18
- [PATCH v5 18/24] tests/avocado: reverse_debugging reverse-step at the end of the trace, Nicholas Piggin, 2024/03/18
- [PATCH v5 19/24] tests/avocado: reverse_debugging.py add snapshot testing, Nicholas Piggin, 2024/03/18

Prev by Date: [PATCH 2/2] tests/qtest/migration: Fix typo for vsock in SocketAddress_to_str
Next by Date: Re: [PATCH v5 15/24] tests/avocado: reverse_debugging.py add test for x86-64 q35 machine
Previous by thread: [PATCH v5 12/24] savevm: Fix load_snapshot error path crash
Next by thread: [PATCH v5 13/24] tests/avocado: replay_linux.py remove the timeout expected guards
Index(es):
- Date
- Thread