qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 07/24] chardev: set record/replay on the base device of a


From: Alex Bennée
Subject: Re: [PATCH v5 07/24] chardev: set record/replay on the base device of a muxed device
Date: Tue, 19 Mar 2024 19:17:40 +0000
User-agent: mu4e 1.12.2; emacs 29.2

Nicholas Piggin <npiggin@gmail.com> writes:

> chardev events to a muxed device don't get recorded because e.g.,
> qemu_chr_be_write() checks whether the base device has the record flag
> set.
>
> This can be seen when replaying a trace that has characters typed into
> the console, an examination of the log shows they are not recorded.
>
> Setting QEMU_CHAR_FEATURE_REPLAY on the base chardev fixes the problem.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro



reply via email to

[Prev in Thread] Current Thread [Next in Thread]