[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 07/24] chardev: set record/replay on the base device of a
From: |
Alex Bennée |
Subject: |
Re: [PATCH v5 07/24] chardev: set record/replay on the base device of a muxed device |
Date: |
Tue, 19 Mar 2024 19:17:40 +0000 |
User-agent: |
mu4e 1.12.2; emacs 29.2 |
Nicholas Piggin <npiggin@gmail.com> writes:
> chardev events to a muxed device don't get recorded because e.g.,
> qemu_chr_be_write() checks whether the base device has the record flag
> set.
>
> This can be seen when replaying a trace that has characters typed into
> the console, an examination of the log shows they are not recorded.
>
> Setting QEMU_CHAR_FEATURE_REPLAY on the base chardev fixes the problem.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
- [PATCH v5 00/24] replay: fixes and new test cases, Nicholas Piggin, 2024/03/18
- [PATCH v5 02/24] scripts/replay-dump.py: rejig decoders in event number order, Nicholas Piggin, 2024/03/18
- [PATCH v5 01/24] scripts/replay-dump.py: Update to current rr record format, Nicholas Piggin, 2024/03/18
- [PATCH v5 03/24] tests/avocado: excercise scripts/replay-dump.py in replay tests, Nicholas Piggin, 2024/03/18
- [PATCH v5 04/24] replay: allow runstate shutdown->running when replaying trace, Nicholas Piggin, 2024/03/18
- [PATCH v5 05/24] Revert "replay: stop us hanging in rr_wait_io_event", Nicholas Piggin, 2024/03/18
- [PATCH v5 06/24] tests/avocado: replay_kernel.py add x86-64 q35 machine test, Nicholas Piggin, 2024/03/18
- [PATCH v5 07/24] chardev: set record/replay on the base device of a muxed device, Nicholas Piggin, 2024/03/18
- Re: [PATCH v5 07/24] chardev: set record/replay on the base device of a muxed device,
Alex Bennée <=
- [PATCH v5 08/24] replay: Fix migration use of clock, Nicholas Piggin, 2024/03/18
- [PATCH v5 10/24] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state, Nicholas Piggin, 2024/03/18
- [PATCH v5 09/24] replay: Fix migration replay_mutex locking, Nicholas Piggin, 2024/03/18
- [PATCH v5 11/24] virtio-net: Use virtual time for RSC timers, Nicholas Piggin, 2024/03/18
- [PATCH v5 12/24] savevm: Fix load_snapshot error path crash, Nicholas Piggin, 2024/03/18
- [PATCH v5 13/24] tests/avocado: replay_linux.py remove the timeout expected guards, Nicholas Piggin, 2024/03/18