Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup()

[Peter Xu]

On Fri, Mar 15, 2024 at 03:31:28PM +0100, Cédric Le Goater wrote:
> On 3/15/24 14:11, Peter Xu wrote:
> > On Fri, Mar 15, 2024 at 01:20:49PM +0100, Cédric Le Goater wrote:
> > > +static void qemu_savevm_wait_unplug(MigrationState *s, int state)
> > 
> > One more trivial comment: I'd even consider dropping "state" altogether, as
> > this should be the only state this function should be invoked.  So we can
> > perhaps assert it instead of passing it over?
> 
> Yes. If you prefer this implementation I will change.

I am fine with either approach, we can wait for 1-2 days to see whether
others want to say.  Otherwise the other approach actually looks better to
me in that it avoids SETUP->UNPLUG->SETUP jumps.

And then we wait to see whether UNPLUG can be dropped for either way to go,
perhaps starting from adding it into deprecation list if no objections from
the relevant folks.

Thanks,

-- 
Peter Xu