|
From: | Cédric Le Goater |
Subject: | Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup() |
Date: | Fri, 15 Mar 2024 15:31:28 +0100 |
User-agent: | Mozilla Thunderbird |
On 3/15/24 14:11, Peter Xu wrote:
On Fri, Mar 15, 2024 at 01:20:49PM +0100, Cédric Le Goater wrote:+static void qemu_savevm_wait_unplug(MigrationState *s, int state)One more trivial comment: I'd even consider dropping "state" altogether, as this should be the only state this function should be invoked. So we can perhaps assert it instead of passing it over?
Yes. If you prefer this implementation I will change. Thanks, C.
[Prev in Thread] | Current Thread | [Next in Thread] |