[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/4] tests/avocado: drop virtio-rng from sbsa-ref tests
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 2/4] tests/avocado: drop virtio-rng from sbsa-ref tests |
Date: |
Thu, 14 Mar 2024 12:27:53 +0000 |
User-agent: |
mu4e 1.12.1; emacs 29.2 |
Peter Maydell <peter.maydell@linaro.org> writes:
> On Thu, 14 Mar 2024 at 12:11, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> writes:
>>
>> > sbsa-ref is supposed to emulate real hardware so virtio-rng-pci
>> > does not fit here
>>
>> What is real anyway ;-)
>>
>> VirtIO devices exist in real life and I would argue for PCI the device
>> appears very much like a normal PCI device. I could see the argument for
>> avoiding virtio-mmio devices which are a lot more VM-only in flavour.
>
> But our platform for testing virtio-rng-pci should be the 'virt'
> board (and our avocado test for virt does indeed have that device).
> What exactly are we adding by testing it also in sbsa-ref,
> where the typical user will *not* be using it (if they wanted
> a virtio setup they would be using 'virt')?
I assume just ensuring the board has enough entropy to boot cleanly. If
it doesn't need it then it doesn't matter I guess.
>
> thanks
> -- PMM
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
- [PATCH v2 1/4] tests/avocado: update sbsa-ref firmware, (continued)
[PATCH v2 2/4] tests/avocado: drop virtio-rng from sbsa-ref tests, Marcin Juszkiewicz, 2024/03/14
[PATCH v2 4/4] tests/avocado: sbsa-ref: add Alpine tests for misc 'max' setup, Marcin Juszkiewicz, 2024/03/14