Re: [PATCH v2 2/4] tests/avocado: drop virtio-rng from sbsa-ref tests

[Alex Bennée]

Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> writes:

> sbsa-ref is supposed to emulate real hardware so virtio-rng-pci
> does not fit here

What is real anyway ;-)

VirtIO devices exist in real life and I would argue for PCI the device
appears very much like a normal PCI device. I could see the argument for
avoiding virtio-mmio devices which are a lot more VM-only in flavour.

>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
>  tests/avocado/machine_aarch64_sbsaref.py | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/tests/avocado/machine_aarch64_sbsaref.py 
> b/tests/avocado/machine_aarch64_sbsaref.py
> index cbab793455..259225f15f 100644
> --- a/tests/avocado/machine_aarch64_sbsaref.py
> +++ b/tests/avocado/machine_aarch64_sbsaref.py
> @@ -132,10 +132,6 @@ def boot_alpine_linux(self, cpu):
>              cpu,
>              "-drive",
>              f"file={iso_path},format=raw",
> -            "-device",
> -            "virtio-rng-pci,rng=rng0",
> -            "-object",
> -            "rng-random,id=rng0,filename=/dev/urandom",
>          )
>  
>          self.vm.launch()
> @@ -179,10 +175,6 @@ def boot_openbsd73(self, cpu):
>              cpu,
>              "-drive",
>              f"file={img_path},format=raw",
> -            "-device",
> -            "virtio-rng-pci,rng=rng0",
> -            "-object",
> -            "rng-random,id=rng0,filename=/dev/urandom",
>          )
>  
>          self.vm.launch()

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro