Re: [PATCH v2 16/16] esp.c: remove explicit setting of DRQ within ESP st

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 16/16] esp.c: remove explicit setting of DRQ within ESP st

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH v2 16/16] esp.c: remove explicit setting of DRQ within ESP state machine
Date:	Wed, 13 Mar 2024 12:01:53 +0100
User-agent:	Mozilla Thunderbird

On 13/3/24 09:58, Mark Cave-Ayland wrote:

Now the esp_update_drq() is called for all reads/writes to the FIFO, there is
no need to manually raise and lower the DRQ signal.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/611
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1831
---
  hw/scsi/esp.c | 9 ---------
  1 file changed, 9 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 12/16] esp.c: move esp_set_phase() and esp_get_phase() towards the beginning of the file, (continued)
- [PATCH v2 12/16] esp.c: move esp_set_phase() and esp_get_phase() towards the beginning of the file, Mark Cave-Ayland, 2024/03/13
  - Re: [PATCH v2 12/16] esp.c: move esp_set_phase() and esp_get_phase() towards the beginning of the file, Philippe Mathieu-Daudé, 2024/03/13
- [PATCH v2 11/16] esp.c: don't overflow cmdfifo if cmdfifo_cdb_offset >= ESP_CMDFIFO_SZ, Mark Cave-Ayland, 2024/03/13
- [PATCH v2 14/16] esp.c: update esp_fifo_{push, pop}() to call esp_update_drq(), Mark Cave-Ayland, 2024/03/13
  - Re: [PATCH v2 14/16] esp.c: update esp_fifo_{push, pop}() to call esp_update_drq(), Philippe Mathieu-Daudé, 2024/03/13
- [PATCH v2 15/16] esp.c: ensure esp_pdma_write() always calls esp_fifo_push(), Mark Cave-Ayland, 2024/03/13
  - Re: [PATCH v2 15/16] esp.c: ensure esp_pdma_write() always calls esp_fifo_push(), Philippe Mathieu-Daudé, 2024/03/13
- [PATCH v2 13/16] esp.c: introduce esp_update_drq() and update esp_fifo_{push, pop}_buf() to use it, Mark Cave-Ayland, 2024/03/13
  - Re: [PATCH v2 13/16] esp.c: introduce esp_update_drq() and update esp_fifo_{push, pop}_buf() to use it, Philippe Mathieu-Daudé, 2024/03/13
- [PATCH v2 16/16] esp.c: remove explicit setting of DRQ within ESP state machine, Mark Cave-Ayland, 2024/03/13
  - Re: [PATCH v2 16/16] esp.c: remove explicit setting of DRQ within ESP state machine, Philippe Mathieu-Daudé <=

Prev by Date: Re: [PATCH v2 14/16] esp.c: update esp_fifo_{push, pop}() to call esp_update_drq()
Next by Date: Re: [PATCH v2 01/16] esp.c: replace cmdfifo use of esp_fifo_pop_buf() in do_command_phase()
Previous by thread: [PATCH v2 16/16] esp.c: remove explicit setting of DRQ within ESP state machine
Next by thread: [PATCH] hw/intc/loongarch_extioi: Fix interrupt routing update
Index(es):
- Date
- Thread