Re: [PATCH v2 14/16] esp.c: update esp_fifo_{push, pop}() to call esp

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 14/16] esp.c: update esp_fifo_{push, pop}() to call esp_up

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH v2 14/16] esp.c: update esp_fifo_{push, pop}() to call esp_update_drq()
Date:	Wed, 13 Mar 2024 12:01:38 +0100
User-agent:	Mozilla Thunderbird

On 13/3/24 09:58, Mark Cave-Ayland wrote:

This ensures that the DRQ line is always set correctly when reading/writing
single bytes to/from the FIFO.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
  hw/scsi/esp.c | 14 ++++++++++----
  1 file changed, 10 insertions(+), 4 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v2 07/16] esp.c: change esp_fifo_pop_buf() to take ESPState, (continued)
- [PATCH v2 08/16] esp.c: introduce esp_fifo_push_buf() function for pushing to the FIFO, Mark Cave-Ayland, 2024/03/13
  - Re: [PATCH v2 08/16] esp.c: introduce esp_fifo_push_buf() function for pushing to the FIFO, Philippe Mathieu-Daudé, 2024/03/13
- [PATCH v2 09/16] esp.c: don't assert() if FIFO empty when executing non-DMA SELATNS, Mark Cave-Ayland, 2024/03/13
  - Re: [PATCH v2 09/16] esp.c: don't assert() if FIFO empty when executing non-DMA SELATNS, Philippe Mathieu-Daudé, 2024/03/13
- [PATCH v2 10/16] esp.c: don't assert() if FIFO empty when executing esp_cdb_length(), Mark Cave-Ayland, 2024/03/13
- [PATCH v2 12/16] esp.c: move esp_set_phase() and esp_get_phase() towards the beginning of the file, Mark Cave-Ayland, 2024/03/13
  - Re: [PATCH v2 12/16] esp.c: move esp_set_phase() and esp_get_phase() towards the beginning of the file, Philippe Mathieu-Daudé, 2024/03/13
- [PATCH v2 11/16] esp.c: don't overflow cmdfifo if cmdfifo_cdb_offset >= ESP_CMDFIFO_SZ, Mark Cave-Ayland, 2024/03/13
- [PATCH v2 14/16] esp.c: update esp_fifo_{push, pop}() to call esp_update_drq(), Mark Cave-Ayland, 2024/03/13
  - Re: [PATCH v2 14/16] esp.c: update esp_fifo_{push, pop}() to call esp_update_drq(), Philippe Mathieu-Daudé <=
- [PATCH v2 15/16] esp.c: ensure esp_pdma_write() always calls esp_fifo_push(), Mark Cave-Ayland, 2024/03/13
  - Re: [PATCH v2 15/16] esp.c: ensure esp_pdma_write() always calls esp_fifo_push(), Philippe Mathieu-Daudé, 2024/03/13
- [PATCH v2 13/16] esp.c: introduce esp_update_drq() and update esp_fifo_{push, pop}_buf() to use it, Mark Cave-Ayland, 2024/03/13
  - Re: [PATCH v2 13/16] esp.c: introduce esp_update_drq() and update esp_fifo_{push, pop}_buf() to use it, Philippe Mathieu-Daudé, 2024/03/13
- [PATCH v2 16/16] esp.c: remove explicit setting of DRQ within ESP state machine, Mark Cave-Ayland, 2024/03/13
  - Re: [PATCH v2 16/16] esp.c: remove explicit setting of DRQ within ESP state machine, Philippe Mathieu-Daudé, 2024/03/13

Prev by Date: Re: [PATCH v2 13/16] esp.c: introduce esp_update_drq() and update esp_fifo_{push, pop}_buf() to use it
Next by Date: Re: [PATCH v2 16/16] esp.c: remove explicit setting of DRQ within ESP state machine
Previous by thread: [PATCH v2 14/16] esp.c: update esp_fifo_{push, pop}() to call esp_update_drq()
Next by thread: [PATCH v2 15/16] esp.c: ensure esp_pdma_write() always calls esp_fifo_push()
Index(es):
- Date
- Thread