[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 08/23] qapi/schema: make c_type() and json_type() abstract met
From: |
John Snow |
Subject: |
[PATCH v4 08/23] qapi/schema: make c_type() and json_type() abstract methods |
Date: |
Wed, 13 Mar 2024 00:41:12 -0400 |
These methods should always return a str, it's only the default abstract
implementation that doesn't. They can be marked "abstract", which
requires subclasses to override the method with the proper return type.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/schema.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
index c549a4e3bd0..c316660adda 100644
--- a/scripts/qapi/schema.py
+++ b/scripts/qapi/schema.py
@@ -16,6 +16,7 @@
# TODO catching name collisions in generated code would be nice
+from abc import ABC, abstractmethod
from collections import OrderedDict
import os
import re
@@ -245,9 +246,10 @@ def visit(self, visitor):
visitor.visit_include(self._sub_module.name, self.info)
-class QAPISchemaType(QAPISchemaDefinition):
+class QAPISchemaType(QAPISchemaDefinition, ABC):
# Return the C type for common use.
# For the types we commonly box, this is a pointer type.
+ @abstractmethod
def c_type(self):
pass
@@ -259,6 +261,7 @@ def c_param_type(self):
def c_unboxed_type(self):
return self.c_type()
+ @abstractmethod
def json_type(self):
pass
--
2.44.0
- Re: [PATCH v4 16/23] qapi/schema: Don't initialize "members" with `None`, (continued)
[PATCH v4 22/23] qapi/schema: turn on mypy strictness, John Snow, 2024/03/13
[PATCH v4 19/23] qapi/parser: demote QAPIExpression to Dict[str, Any], John Snow, 2024/03/13
[PATCH v4 15/23] qapi/schema: add _check_complete flag, John Snow, 2024/03/13
[PATCH v4 11/23] qapi/schema: assert resolve_type has 'info' and 'what' args on error, John Snow, 2024/03/13
[PATCH v4 20/23] qapi/parser.py: assert member.info is present in connect_member, John Snow, 2024/03/13
[PATCH v4 21/23] qapi/schema: add type hints, John Snow, 2024/03/13
[PATCH v4 08/23] qapi/schema: make c_type() and json_type() abstract methods,
John Snow <=
[PATCH v4 06/23] qapi/schema: declare type for QAPISchemaObjectTypeMember.type, John Snow, 2024/03/13
[PATCH v4 10/23] qapi/schema: add type narrowing to lookup_type(), John Snow, 2024/03/13
[PATCH v4 23/23] qapi/schema: remove unnecessary asserts, John Snow, 2024/03/13
Re: [PATCH v4 00/23] qapi: statically type schema.py, Markus Armbruster, 2024/03/14