[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/38] target/ppc: Fix GDB SPR regnum indexing
From: |
Nicholas Piggin |
Subject: |
[PULL 01/38] target/ppc: Fix GDB SPR regnum indexing |
Date: |
Wed, 13 Mar 2024 02:58:12 +1000 |
Fix an off by one bug.
Fixes: 1b53948ff8f70 ("target/ppc: Use GDBFeature for dynamic XML")
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
target/ppc/gdbstub.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c
index 122ea9d0c0..80a2e7990b 100644
--- a/target/ppc/gdbstub.c
+++ b/target/ppc/gdbstub.c
@@ -324,6 +324,9 @@ static void gdb_gen_spr_feature(CPUState *cs)
continue;
}
+ gdb_feature_builder_append_reg(&builder, g_ascii_strdown(spr->name,
-1),
+ TARGET_LONG_BITS, num_regs,
+ "int", "spr");
/*
* GDB identifies registers based on the order they are
* presented in the XML. These ids will not match QEMU's
@@ -334,10 +337,6 @@ static void gdb_gen_spr_feature(CPUState *cs)
*/
spr->gdb_id = num_regs;
num_regs++;
-
- gdb_feature_builder_append_reg(&builder, g_ascii_strdown(spr->name,
-1),
- TARGET_LONG_BITS, num_regs,
- "int", "spr");
}
gdb_feature_builder_end(&builder);
--
2.42.0
- [PULL 00/38] ppc-for-9.0-2 queue, Nicholas Piggin, 2024/03/12
- [PULL 01/38] target/ppc: Fix GDB SPR regnum indexing,
Nicholas Piggin <=
- [PULL 03/38] spapr: set MSR[ME] and MSR[FP] on client entry, Nicholas Piggin, 2024/03/12
- [PULL 02/38] target/ppc: Prevent supervisor from modifying MSR[ME], Nicholas Piggin, 2024/03/12
- [PULL 04/38] ppc: Drop support for POWER9 and POWER10 DD1 chips, Nicholas Piggin, 2024/03/12
- [PULL 05/38] target/ppc: POWER10 does not have transactional memory, Nicholas Piggin, 2024/03/12
- [PULL 06/38] ppc/spapr|pnv: Remove SAO from pa-features, Nicholas Piggin, 2024/03/12
- [PULL 07/38] ppc/spapr: Remove copy-paste from pa-features, Nicholas Piggin, 2024/03/12
- [PULL 08/38] ppc/spapr: Adjust ibm,pa-features for POWER9, Nicholas Piggin, 2024/03/12
- [PULL 10/38] ppc/pnv: Permit ibm,pa-features set per machine variant, Nicholas Piggin, 2024/03/12
- [PULL 11/38] ppc/pnv: Set POWER9, POWER10 ibm,pa-features bits, Nicholas Piggin, 2024/03/12
- [PULL 09/38] ppc/spapr: Add pa-features for POWER10 machines, Nicholas Piggin, 2024/03/12