[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/13] meson.build: Always require an objc compiler on macos hosts
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 12/13] meson.build: Always require an objc compiler on macos hosts |
Date: |
Tue, 12 Mar 2024 09:22:37 +0100 |
From: Peter Maydell <peter.maydell@linaro.org>
We currently only insist that an ObjectiveC compiler is present on
macos hosts if we're building the Cocoa UI. However, since then
we've added some other parts of QEMU which are also written in ObjC:
the coreaudio audio backend, and the vmnet net backend. This means
that if you try to configure QEMU on macos with --disable-cocoa the
build will fail:
../meson.build:3741:13: ERROR: No host machine compiler for 'audio/coreaudio.m'
Since in practice any macos host will have an ObjC compiler
available, rather than trying to gate the compiler detection on an
increasingly complicated list of every bit of QEMU that uses ObjC,
just require it unconditionally on macos hosts.
Resolves https://gitlab.com/qemu-project/qemu/-/issues/2138
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20240311133334.3991537-1-peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index f9dbe7634e..e3fab8ce9f 100644
--- a/meson.build
+++ b/meson.build
@@ -66,7 +66,7 @@ if host_os == 'windows' and add_languages('cpp', required:
false, native: false)
cxx = meson.get_compiler('cpp')
endif
if host_os == 'darwin' and \
- add_languages('objc', required: get_option('cocoa'), native: false)
+ add_languages('objc', required: true, native: false)
all_languages += ['objc']
objc = meson.get_compiler('objc')
endif
--
2.41.0
- [PULL 02/13] hw/pci: add some convenient trace-events for pcie and shpc hotplug, (continued)
- [PULL 02/13] hw/pci: add some convenient trace-events for pcie and shpc hotplug, Philippe Mathieu-Daudé, 2024/03/12
- [PULL 03/13] hw/ppc/sam460ex: Support short options for adding drives, Philippe Mathieu-Daudé, 2024/03/12
- [PULL 04/13] hw/core/loader-fit: Fix missing ERRP_GUARD() for error_prepend(), Philippe Mathieu-Daudé, 2024/03/12
- [PULL 05/13] hw/core/qdev-properties-system: Fix missing ERRP_GUARD() for error_prepend(), Philippe Mathieu-Daudé, 2024/03/12
- [PULL 06/13] hw/misc/ivshmem: Fix missing ERRP_GUARD() for error_prepend(), Philippe Mathieu-Daudé, 2024/03/12
- [PULL 07/13] sun4u: remap ebus BAR0 to use unassigned_io_ops instead of alias to PCI IO space, Philippe Mathieu-Daudé, 2024/03/12
- [PULL 08/13] hw/core: Cleanup unused included headers in cpu-common.c, Philippe Mathieu-Daudé, 2024/03/12
- [PULL 09/13] hw/core: Cleanup unused included header in machine-qmp-cmds.c, Philippe Mathieu-Daudé, 2024/03/12
- [PULL 11/13] hw/gpio: introduce pcf8574 driver, Philippe Mathieu-Daudé, 2024/03/12
- [PULL 10/13] hw/core: Cleanup unused included headers in numa.c, Philippe Mathieu-Daudé, 2024/03/12
- [PULL 12/13] meson.build: Always require an objc compiler on macos hosts,
Philippe Mathieu-Daudé <=
- [PULL 13/13] docs/about/deprecated.rst: Move SMP configurations item to system emulator section, Philippe Mathieu-Daudé, 2024/03/12
- Re: [PULL 00/13] Misc HW patches for 2024-03-12, Peter Maydell, 2024/03/12