Re: [PATCH v4 3/8] Replace migrate_get_connect_uri inplace of migrate_get_socket_address

[Het Gala]

On 12/03/24 2:21 am, Fabiano Rosas wrote:

> Het Gala <het.gala@nutanix.com> writes:
>
> > On 11/03/24 11:49 pm, Fabiano Rosas wrote:
> > > Het Gala<het.gala@nutanix.com>  writes:
> > >
> > > >   bool migrate_watch_for_events(QTestState *who, const char *name,
> > > > @@ -130,7 +140,7 @@ void migrate_qmp(QTestState *who, QTestState *to, const char *uri,
> > > >   
> > > >       g_assert(!qdict_haskey(args, "uri"));
> > > >       if (!uri) {
> > > > -        connect_uri = migrate_get_socket_address(to, "socket-address");
> > > > +        connect_uri = migrate_get_connect_uri(to, "socket-address");
> > > >           
> > > What's the point of the "socket-address" argument here? Seems a bit
> > > nonsensical to me to call: migrate_get_socket_address(..., "socket-address").
> > >
> > > What about we just suppress this throughout the stack and directly call:
> > >
> > >      object = qdict_get(rsp, "socket-address");
> > >         
> > Fabiano, I didn't get clearly understand your point here. From what I 
> > understand,
> > you want to call just
> > 1. migrate_get_connect_uri(to) and migrate_get_connect_qdict(to)
> >       
> Yes.
>     
    Ack
> > 2. delete migrate_get_socket_address(..., "socket-address") altogether 
> >       
> No, just the string argument, not the whole function:
>
> static char *migrate_get_socket_address(QTestState *who) <----
> {
>     QDict *rsp;
>     char *result;
>     SocketAddressList *addrs;
>     Visitor *iv = NULL;
>     QObject *object;
>
>     rsp = migrate_query(who);
>     object = qdict_get(rsp, "socket-address"); <-----
>     ...
> }
>
> If the thing is called migrate_get_SOCKET_ADDRESS(), it's obvious that
> the "socket-address" is the parameter we want. We even call
> SocketAddress_to_str, so there's no point in having that argument
> there. We will never call the function with something else in
> 'parameter'.
>     
    Ahh, okay. I got your point, and yes, it
      makes sense. Will just call 
      migrate_get_socket_address(to) and let the qdict_get() call 
"socket-address" internally.

Regards,

Het Gala