Re: [PATCH v4 2/8] Replace connect_uri and move migrate_get_socket_address inside migrate_qmp

[Het Gala]

On 11/03/24 11:46 pm, Fabiano Rosas wrote:
> Het Gala <het.gala@nutanix.com> writes:
>
> > Move the calls to migrate_get_socket_address() into migrate_qmp().
> > Get rid of connect_uri and replace it with args->connect_uri only
> > because 'to' object will help to generate connect_uri with the
> > correct port number.
> >
> > Signed-off-by: Het Gala <het.gala@nutanix.com>
> > Suggested-by: Fabiano Rosas <farosas@suse.de>
> > Reviewed-by: Fabiano Rosas <farosas@suse.de>
> > ---
> >   tests/qtest/migration-helpers.c | 55 ++++++++++++++++++++++-
> >   tests/qtest/migration-test.c    | 79 +++++----------------------------
> >   2 files changed, 64 insertions(+), 70 deletions(-)
> >
> > diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c
> > index b6206a04fb..9af3c7d4d5 100644
> > --- a/tests/qtest/migration-helpers.c
> > +++ b/tests/qtest/migration-helpers.c
> > @@ -13,6 +13,10 @@
> >   #include "qemu/osdep.h"
> >   #include "qemu/ctype.h"
> >   #include "qapi/qmp/qjson.h"
> > +#include "qemu/sockets.h"
> > +#include "qapi/qapi-visit-sockets.h"
> > +#include "qapi/qobject-input-visitor.h"
> > +#include "qapi/error.h"
> Are any of these now superfluous at migration-test.c?

Yess, actually all of them are now redundant or not required from the 
migration-test.c. Will remove all imports from there


Regards,

Het Gala

>