[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] Revert "hw/i386/pc: Confine system flash handling to pc_
|
From: |
Alex Williamson |
|
Subject: |
Re: [PATCH 0/2] Revert "hw/i386/pc: Confine system flash handling to pc_sysfw" |
|
Date: |
Sat, 9 Mar 2024 08:13:27 -0700 |
On Mon, 26 Feb 2024 22:59:07 +0100
Bernhard Beschow <shentey@gmail.com> wrote:
> As reported by Volker [1], commit 6f6ad2b24582 "hw/i386/pc: Confine system
> flash handling to pc_sysfw" causes a regression when specifying the property
> `-M pflash0` in the PCI PC machines:
> qemu-system-x86_64: Property 'pc-q35-9.0-machine.pflash0' not found
> Revert the commit for now until a solution is found.
>
> Best regards,
> Bernhard
>
> [1]
> https://lore.kernel.org/qemu-devel/9e82a04b-f2c1-4e34-b4b6-46a0581b572f@t-online.de/
>
> Bernhard Beschow (2):
> Revert "hw/i386/pc_sysfw: Inline pc_system_flash_create() and remove
> it"
> Revert "hw/i386/pc: Confine system flash handling to pc_sysfw"
>
> include/hw/i386/pc.h | 2 ++
> hw/i386/pc.c | 1 +
> hw/i386/pc_piix.c | 1 +
> hw/i386/pc_sysfw.c | 17 +++++++++++++----
> 4 files changed, 17 insertions(+), 4 deletions(-)
>
Please apply this, the original commits break my existing VMs.
Tested-by: Alex Williamson <alex.williamson@redhat.com>