Re: [PATCH 1/2] gdbstub: Add Xfer:siginfo:read stub

[Gustavo Romero]

On 3/4/24 2:18 PM, Richard Henderson wrote:
> On 3/3/24 09:26, Gustavo Romero wrote:
> > +    /* Filter out si_type from si_code. See comment in siginfo_noswap(). */ > +   
> >  tmp_siginfo = ts->sync_signal.info;
> > +    tmp_siginfo.si_code = sextract32(tmp_siginfo.si_code, 0, 16);
>
>
> This is incorrect, as it only handles synchronous signals.
>
> In handle_pending_signal(), struct emulated_sigtable is passed, which has the 
> correct siginfo (all of it, so no need for the adjustment).  I think you need 
> to pass that in to gdb_handlesig so that a copy can be made for later xfer.

Thanks, I'm sending v2 that fixes it.


Cheers,
Gustavo