qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] gdbstub: Add Xfer:siginfo:read stub


From: Richard Henderson
Subject: Re: [PATCH 1/2] gdbstub: Add Xfer:siginfo:read stub
Date: Mon, 4 Mar 2024 07:18:19 -1000
User-agent: Mozilla Thunderbird

On 3/3/24 09:26, Gustavo Romero wrote:
+    /* Filter out si_type from si_code. See comment in siginfo_noswap(). */ > +   
 tmp_siginfo = ts->sync_signal.info;
+    tmp_siginfo.si_code = sextract32(tmp_siginfo.si_code, 0, 16);


This is incorrect, as it only handles synchronous signals.

In handle_pending_signal(), struct emulated_sigtable is passed, which has the correct siginfo (all of it, so no need for the adjustment). I think you need to pass that in to gdb_handlesig so that a copy can be made for later xfer.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]