[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 07/19] contrib/elf2dmp: Fix error reporting style in pdb.c
From: |
Peter Maydell |
Subject: |
Re: [PATCH v4 07/19] contrib/elf2dmp: Fix error reporting style in pdb.c |
Date: |
Thu, 7 Mar 2024 13:10:05 +0000 |
On Thu, 7 Mar 2024 at 10:21, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> include/qapi/error.h says:
> > We recommend
> > * bool-valued functions return true on success / false on failure,
> > ...
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> contrib/elf2dmp/pdb.h | 2 +-
> contrib/elf2dmp/main.c | 2 +-
> contrib/elf2dmp/pdb.c | 50
> +++++++++++++++++++++++++-------------------------
> 3 files changed, 27 insertions(+), 27 deletions(-)
>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v4 01/19] contrib/elf2dmp: Remove unnecessary err flags, (continued)
- [PATCH v4 01/19] contrib/elf2dmp: Remove unnecessary err flags, Akihiko Odaki, 2024/03/07
- [PATCH v4 02/19] contrib/elf2dmp: Assume error by default, Akihiko Odaki, 2024/03/07
- [PATCH v4 03/19] contrib/elf2dmp: Continue even contexts are lacking, Akihiko Odaki, 2024/03/07
- [PATCH v4 04/19] contrib/elf2dmp: Change pa_space_create() signature, Akihiko Odaki, 2024/03/07
- [PATCH v4 05/19] contrib/elf2dmp: Fix error reporting style in addrspace.c, Akihiko Odaki, 2024/03/07
- [PATCH v4 06/19] contrib/elf2dmp: Fix error reporting style in download.c, Akihiko Odaki, 2024/03/07
- [PATCH v4 07/19] contrib/elf2dmp: Fix error reporting style in pdb.c, Akihiko Odaki, 2024/03/07
- Re: [PATCH v4 07/19] contrib/elf2dmp: Fix error reporting style in pdb.c,
Peter Maydell <=
- [PATCH v4 08/19] contrib/elf2dmp: Fix error reporting style in qemu_elf.c, Akihiko Odaki, 2024/03/07
- [PATCH v4 09/19] contrib/elf2dmp: Fix error reporting style in main.c, Akihiko Odaki, 2024/03/07
- [PATCH v4 10/19] contrib/elf2dmp: Always check for PA resolution failure, Akihiko Odaki, 2024/03/07
- [PATCH v4 11/19] contrib/elf2dmp: Always destroy PA space, Akihiko Odaki, 2024/03/07
- [PATCH v4 14/19] contrib/elf2dmp: Use rol64() to decode, Akihiko Odaki, 2024/03/07
- [PATCH v4 15/19] MAINTAINERS: Add Akihiko Odaki as a elf2dmp reviewer, Akihiko Odaki, 2024/03/07