[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 11/19] contrib/elf2dmp: Always destroy PA space
From: |
Akihiko Odaki |
Subject: |
[PATCH v4 11/19] contrib/elf2dmp: Always destroy PA space |
Date: |
Thu, 07 Mar 2024 19:20:54 +0900 |
Destroy PA space even if paging base couldn't be found, fixing memory
leak.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
contrib/elf2dmp/main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c
index 9347b0cd5a2d..32dc8bac6a30 100644
--- a/contrib/elf2dmp/main.c
+++ b/contrib/elf2dmp/main.c
@@ -549,7 +549,7 @@ int main(int argc, char *argv[])
va_space_create(&vs, &ps, state->cr[3]);
if (!fix_dtb(&vs, &qemu_elf)) {
eprintf("Failed to find paging base\n");
- goto out_elf;
+ goto out_ps;
}
printf("CPU #0 IDT is at 0x%016"PRIx64"\n", state->idt.base);
@@ -634,7 +634,6 @@ out_pdb_file:
unlink(PDB_NAME);
out_ps:
pa_space_destroy(&ps);
-out_elf:
QEMU_Elf_exit(&qemu_elf);
return err;
--
2.44.0
- Re: [PATCH v4 05/19] contrib/elf2dmp: Fix error reporting style in addrspace.c, (continued)
- [PATCH v4 06/19] contrib/elf2dmp: Fix error reporting style in download.c, Akihiko Odaki, 2024/03/07
- [PATCH v4 07/19] contrib/elf2dmp: Fix error reporting style in pdb.c, Akihiko Odaki, 2024/03/07
- [PATCH v4 08/19] contrib/elf2dmp: Fix error reporting style in qemu_elf.c, Akihiko Odaki, 2024/03/07
- [PATCH v4 09/19] contrib/elf2dmp: Fix error reporting style in main.c, Akihiko Odaki, 2024/03/07
- [PATCH v4 10/19] contrib/elf2dmp: Always check for PA resolution failure, Akihiko Odaki, 2024/03/07
- [PATCH v4 11/19] contrib/elf2dmp: Always destroy PA space,
Akihiko Odaki <=
- [PATCH v4 14/19] contrib/elf2dmp: Use rol64() to decode, Akihiko Odaki, 2024/03/07
- [PATCH v4 15/19] MAINTAINERS: Add Akihiko Odaki as a elf2dmp reviewer, Akihiko Odaki, 2024/03/07
- [PATCH v4 12/19] contrib/elf2dmp: Ensure segment fits in file, Akihiko Odaki, 2024/03/07
- [PATCH v4 16/19] contrib/elf2dmp: Build only for little endian host, Akihiko Odaki, 2024/03/07
- [PATCH v4 17/19] contrib/elf2dmp: Use GPtrArray, Akihiko Odaki, 2024/03/07
- [PATCH v4 18/19] contrib/elf2dmp: Clamp QEMU note to file size, Akihiko Odaki, 2024/03/07
- [PATCH v4 13/19] contrib/elf2dmp: Use lduw_le_p() to read PDB, Akihiko Odaki, 2024/03/07