[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] hw/i386/pc: Have pc_init_isa() pass a NULL pci_type argu
|
From: |
Bernhard Beschow |
|
Subject: |
Re: [PATCH 4/4] hw/i386/pc: Have pc_init_isa() pass a NULL pci_type argument |
|
Date: |
Sat, 02 Mar 2024 10:03:50 +0000 |
Am 1. März 2024 18:59:36 UTC schrieb "Philippe Mathieu-Daudé"
<philmd@linaro.org>:
>The "isapc" machine only provides an ISA bus, not a PCI one,
>and doesn't instanciate any i440FX south bridge.
>Its machine class defines PCMachineClass::pci_enabled = false,
>and pc_init1() only uses the pci_type argument when pci_enabled
>is true. Since for this machine the argument is not used,
>passing NULL makes more sense.
>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Bernhard Beschow <shentey@gmail.com>
- [PATCH 0/4] hw/i386/pc: Trivial cleanups, Philippe Mathieu-Daudé, 2024/03/01
- [PATCH 1/4] hw/i386/pc: Remove pc_compat_1_4..1.7[] left over declarations, Philippe Mathieu-Daudé, 2024/03/01
- [PATCH 2/4] hw/i386/pc: Use generated NotifyVmexitOption_str(), Philippe Mathieu-Daudé, 2024/03/01
- [PATCH 3/4] hw/i386/pc: Remove 'host_type' argument from pc_init1(), Philippe Mathieu-Daudé, 2024/03/01
- [PATCH 4/4] hw/i386/pc: Have pc_init_isa() pass a NULL pci_type argument, Philippe Mathieu-Daudé, 2024/03/01
- Re: [PATCH 4/4] hw/i386/pc: Have pc_init_isa() pass a NULL pci_type argument,
Bernhard Beschow <=
- Re: [PATCH 0/4] hw/i386/pc: Trivial cleanups, Bernhard Beschow, 2024/03/07