Re: [PATCH v8 14/15] hw/pci: Determine if rombar is explicitly enabled

[Markus Armbruster]

Akihiko Odaki <akihiko.odaki@daynix.com> writes:

> vfio determines if rombar is explicitly enabled by inspecting QDict.
> Inspecting QDict is not nice because QDict is untyped and depends on the
> details on the external interface. Add an infrastructure to determine if
> rombar is explicitly enabled to hw/pci.
>
> This changes the semantics of UINT32_MAX, which has always been a valid
> value to explicitly say rombar is enabled to denote the implicit default
> value. Nobody should have been set UINT32_MAX to rombar however,
> considering that its meaning was no different from 1 and typing a
> literal UINT32_MAX (0xffffffff or 4294967295) is more troublesome.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

Remark on the previous patch applies.

Reviewed-by: Markus Armbruster <armbru@redhat.com>