[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v12 01/10] ui/cocoa: Split [-QemuCocoaView handleEventLocked:
From: |
Peter Maydell |
Subject: |
Re: [PATCH v12 01/10] ui/cocoa: Split [-QemuCocoaView handleEventLocked:] |
Date: |
Mon, 26 Feb 2024 16:58:05 +0000 |
On Sat, 24 Feb 2024 at 12:43, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> Currently [-QemuCocoaView handleEventLocked:] parses the passed event,
> stores operations to be done to variables, and perform them according
> to the variables. This construct will be cluttered with variables and
> hard to read when we need more different operations for different
> events.
>
> Split the methods so that we can call appropriate methods depending on
> events instead of relying on variables.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v12 00/10] ui/cocoa: Use NSWindow's ability to resize, Akihiko Odaki, 2024/02/24
- [PATCH v12 01/10] ui/cocoa: Split [-QemuCocoaView handleEventLocked:], Akihiko Odaki, 2024/02/24
- Re: [PATCH v12 01/10] ui/cocoa: Split [-QemuCocoaView handleEventLocked:],
Peter Maydell <=
- [PATCH v12 02/10] ui/cocoa: Immediately call [-QemuCocoaView handleMouseEvent:buttons:], Akihiko Odaki, 2024/02/24
- [PATCH v12 03/10] ui/cocoa: Release specific mouse buttons, Akihiko Odaki, 2024/02/24
- [PATCH v12 04/10] ui/cocoa: Scale with NSView instead of Core Graphics, Akihiko Odaki, 2024/02/24
- [PATCH v12 05/10] ui/cocoa: Fix pause label coordinates, Akihiko Odaki, 2024/02/24
- [PATCH v12 06/10] ui/cocoa: Let the platform toggle fullscreen, Akihiko Odaki, 2024/02/24
- [PATCH v12 07/10] ui/cocoa: Remove normalWindow, Akihiko Odaki, 2024/02/24