[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 07/14] libvhost-user: Don't zero out memory for memory regions
From: |
David Hildenbrand |
Subject: |
[PATCH v2 07/14] libvhost-user: Don't zero out memory for memory regions |
Date: |
Wed, 14 Feb 2024 16:16:54 +0100 |
dev->nregions always covers only valid entries. Stop zeroing out other
array elements that are unused.
Reviewed-by: Raphael Norwitz <raphael@enfabrica.net>
Acked-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
subprojects/libvhost-user/libvhost-user.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/subprojects/libvhost-user/libvhost-user.c
b/subprojects/libvhost-user/libvhost-user.c
index 225283f764..2e8b611385 100644
--- a/subprojects/libvhost-user/libvhost-user.c
+++ b/subprojects/libvhost-user/libvhost-user.c
@@ -888,13 +888,9 @@ vu_rem_mem_reg(VuDev *dev, VhostUserMsg *vmsg) {
munmap((void *)(uintptr_t)r->mmap_addr, r->size + r->mmap_offset);
- /*
- * Shift all affected entries by 1 to close the hole at index i and
- * zero out the last entry.
- */
+ /* Shift all affected entries by 1 to close the hole at index. */
memmove(dev->regions + i, dev->regions + i + 1,
sizeof(VuDevRegion) * (dev->nregions - i - 1));
- memset(dev->regions + dev->nregions - 1, 0, sizeof(VuDevRegion));
DPRINT("Successfully removed a region\n");
dev->nregions--;
i--;
@@ -2119,7 +2115,6 @@ vu_init(VuDev *dev,
DPRINT("%s: failed to malloc mem regions\n", __func__);
return false;
}
- memset(dev->regions, 0, VHOST_USER_MAX_RAM_SLOTS *
sizeof(dev->regions[0]));
dev->vq = malloc(max_queues * sizeof(dev->vq[0]));
if (!dev->vq) {
--
2.43.0
- [PATCH v2 00/14] libvhost-user: support more memslots and cleanup memslot handling code, David Hildenbrand, 2024/02/14
- [PATCH v2 01/14] libvhost-user: Dynamically allocate memory for memory slots, David Hildenbrand, 2024/02/14
- [PATCH v2 02/14] libvhost-user: Bump up VHOST_USER_MAX_RAM_SLOTS to 509, David Hildenbrand, 2024/02/14
- [PATCH v2 03/14] libvhost-user: Factor out removing all mem regions, David Hildenbrand, 2024/02/14
- [PATCH v2 04/14] libvhost-user: Merge vu_set_mem_table_exec_postcopy() into vu_set_mem_table_exec(), David Hildenbrand, 2024/02/14
- [PATCH v2 05/14] libvhost-user: Factor out adding a memory region, David Hildenbrand, 2024/02/14
- [PATCH v2 06/14] libvhost-user: No need to check for NULL when unmapping, David Hildenbrand, 2024/02/14
- [PATCH v2 07/14] libvhost-user: Don't zero out memory for memory regions,
David Hildenbrand <=
- [PATCH v2 08/14] libvhost-user: Don't search for duplicates when removing memory regions, David Hildenbrand, 2024/02/14
- [PATCH v2 09/14] libvhost-user: Factor out search for memory region by GPA and simplify, David Hildenbrand, 2024/02/14
- [PATCH v2 10/14] libvhost-user: Speedup gpa_to_mem_region() and vu_gpa_to_va(), David Hildenbrand, 2024/02/14
- [PATCH v2 11/14] libvhost-user: Use most of mmap_offset as fd_offset, David Hildenbrand, 2024/02/14
- [PATCH v2 12/14] libvhost-user: Factor out vq usability check, David Hildenbrand, 2024/02/14
- [PATCH v2 13/14] libvhost-user: Dynamically remap rings after (temporarily?) removing memory regions, David Hildenbrand, 2024/02/14
- [PATCH v2 14/14] libvhost-user: Mark mmap'ed region memory as MADV_DONTDUMP, David Hildenbrand, 2024/02/14