[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 06/14] libvhost-user: No need to check for NULL when unmapping
From: |
David Hildenbrand |
Subject: |
[PATCH v2 06/14] libvhost-user: No need to check for NULL when unmapping |
Date: |
Wed, 14 Feb 2024 16:16:53 +0100 |
We never add a memory region if mmap() failed. Therefore, no need to check
for NULL.
Reviewed-by: Raphael Norwitz <raphael@enfabrica.net>
Acked-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
subprojects/libvhost-user/libvhost-user.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/subprojects/libvhost-user/libvhost-user.c
b/subprojects/libvhost-user/libvhost-user.c
index f43b5096d0..225283f764 100644
--- a/subprojects/libvhost-user/libvhost-user.c
+++ b/subprojects/libvhost-user/libvhost-user.c
@@ -247,11 +247,8 @@ vu_remove_all_mem_regs(VuDev *dev)
for (i = 0; i < dev->nregions; i++) {
VuDevRegion *r = &dev->regions[i];
- void *ma = (void *)(uintptr_t)r->mmap_addr;
- if (ma) {
- munmap(ma, r->size + r->mmap_offset);
- }
+ munmap((void *)(uintptr_t)r->mmap_addr, r->size + r->mmap_offset);
}
dev->nregions = 0;
}
@@ -888,11 +885,8 @@ vu_rem_mem_reg(VuDev *dev, VhostUserMsg *vmsg) {
for (i = 0; i < dev->nregions; i++) {
if (reg_equal(&dev->regions[i], msg_region)) {
VuDevRegion *r = &dev->regions[i];
- void *ma = (void *) (uintptr_t) r->mmap_addr;
- if (ma) {
- munmap(ma, r->size + r->mmap_offset);
- }
+ munmap((void *)(uintptr_t)r->mmap_addr, r->size + r->mmap_offset);
/*
* Shift all affected entries by 1 to close the hole at index i and
--
2.43.0
- [PATCH v2 00/14] libvhost-user: support more memslots and cleanup memslot handling code, David Hildenbrand, 2024/02/14
- [PATCH v2 01/14] libvhost-user: Dynamically allocate memory for memory slots, David Hildenbrand, 2024/02/14
- [PATCH v2 02/14] libvhost-user: Bump up VHOST_USER_MAX_RAM_SLOTS to 509, David Hildenbrand, 2024/02/14
- [PATCH v2 03/14] libvhost-user: Factor out removing all mem regions, David Hildenbrand, 2024/02/14
- [PATCH v2 04/14] libvhost-user: Merge vu_set_mem_table_exec_postcopy() into vu_set_mem_table_exec(), David Hildenbrand, 2024/02/14
- [PATCH v2 05/14] libvhost-user: Factor out adding a memory region, David Hildenbrand, 2024/02/14
- [PATCH v2 06/14] libvhost-user: No need to check for NULL when unmapping,
David Hildenbrand <=
- [PATCH v2 07/14] libvhost-user: Don't zero out memory for memory regions, David Hildenbrand, 2024/02/14
- [PATCH v2 08/14] libvhost-user: Don't search for duplicates when removing memory regions, David Hildenbrand, 2024/02/14
- [PATCH v2 09/14] libvhost-user: Factor out search for memory region by GPA and simplify, David Hildenbrand, 2024/02/14
- [PATCH v2 10/14] libvhost-user: Speedup gpa_to_mem_region() and vu_gpa_to_va(), David Hildenbrand, 2024/02/14
- [PATCH v2 11/14] libvhost-user: Use most of mmap_offset as fd_offset, David Hildenbrand, 2024/02/14
- [PATCH v2 12/14] libvhost-user: Factor out vq usability check, David Hildenbrand, 2024/02/14
- [PATCH v2 13/14] libvhost-user: Dynamically remap rings after (temporarily?) removing memory regions, David Hildenbrand, 2024/02/14
- [PATCH v2 14/14] libvhost-user: Mark mmap'ed region memory as MADV_DONTDUMP, David Hildenbrand, 2024/02/14