[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 48/61] hw/riscv/virt.c: use g_autofree in virt_machine_init()
From: |
Alistair Francis |
Subject: |
[PULL 48/61] hw/riscv/virt.c: use g_autofree in virt_machine_init() |
Date: |
Fri, 9 Feb 2024 20:58:00 +1000 |
From: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Move 'soc_name' to the loop, and give it g_autofree, to avoid the manual
g_free().
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240122221529.86562-7-dbarboza@ventanamicro.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
hw/riscv/virt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index f8278df83f..710fbbda2c 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -1356,7 +1356,6 @@ static void virt_machine_init(MachineState *machine)
RISCVVirtState *s = RISCV_VIRT_MACHINE(machine);
MemoryRegion *system_memory = get_system_memory();
MemoryRegion *mask_rom = g_new(MemoryRegion, 1);
- char *soc_name;
DeviceState *mmio_irqchip, *virtio_irqchip, *pcie_irqchip;
int i, base_hartid, hart_count;
int socket_count = riscv_socket_count(machine);
@@ -1376,6 +1375,8 @@ static void virt_machine_init(MachineState *machine)
/* Initialize sockets */
mmio_irqchip = virtio_irqchip = pcie_irqchip = NULL;
for (i = 0; i < socket_count; i++) {
+ g_autofree char *soc_name = g_strdup_printf("soc%d", i);
+
if (!riscv_socket_check_hartids(machine, i)) {
error_report("discontinuous hartids in socket%d", i);
exit(1);
@@ -1393,10 +1394,8 @@ static void virt_machine_init(MachineState *machine)
exit(1);
}
- soc_name = g_strdup_printf("soc%d", i);
object_initialize_child(OBJECT(machine), soc_name, &s->soc[i],
TYPE_RISCV_HART_ARRAY);
- g_free(soc_name);
object_property_set_str(OBJECT(&s->soc[i]), "cpu-type",
machine->cpu_type, &error_abort);
object_property_set_int(OBJECT(&s->soc[i]), "hartid-base",
--
2.43.0
- [PULL 27/61] target/riscv/insn_trans/trans_rvvk.c.inc: use 'vlenb', (continued)
- [PULL 27/61] target/riscv/insn_trans/trans_rvvk.c.inc: use 'vlenb', Alistair Francis, 2024/02/09
- [PULL 28/61] target/riscv/vector_helper.c: use 'vlenb', Alistair Francis, 2024/02/09
- [PULL 29/61] target/riscv/vector_helper.c: use vlenb in HELPER(vsetvl), Alistair Francis, 2024/02/09
- [PULL 30/61] target/riscv/insn_trans/trans_rvv.c.inc: use 'vlenb' in MAXSZ(), Alistair Francis, 2024/02/09
- [PULL 33/61] trans_rvv.c.inc: use vext_get_vlmax() in trans_vrgather_v*(), Alistair Francis, 2024/02/09
- [PULL 37/61] target/riscv/kvm: get/set vector vregs[], Alistair Francis, 2024/02/09
- [PULL 38/61] target/riscv: Remove misa_mxl validation, Alistair Francis, 2024/02/09
- [PULL 39/61] target/riscv: Move misa_mxl_max to class, Alistair Francis, 2024/02/09
- [PULL 52/61] target/riscv: Expose Zaamo and Zalrsc extensions, Alistair Francis, 2024/02/09
- [PULL 45/61] hw/riscv/virt.c: use g_autofree in create_fdt_socket_cpus(), Alistair Francis, 2024/02/09
- [PULL 48/61] hw/riscv/virt.c: use g_autofree in virt_machine_init(),
Alistair Francis <=
- [PULL 35/61] target/riscv/kvm: change kvm_reg_id to uint64_t, Alistair Francis, 2024/02/09
- [PULL 36/61] target/riscv/kvm: initialize 'vlenb' via get-reg-list, Alistair Francis, 2024/02/09
- [PULL 46/61] hw/riscv/virt.c: use g_autofree in create_fdt_sockets(), Alistair Francis, 2024/02/09
- [PULL 49/61] hw/riscv/virt.c: use g_autofree in create_fdt_*, Alistair Francis, 2024/02/09
- [PULL 55/61] smbios: add processor-family option, Alistair Francis, 2024/02/09
- [PULL 59/61] target/riscv: Enable xtheadsync under user mode, Alistair Francis, 2024/02/09
- [PULL 61/61] target/riscv: add rv32i, rv32e and rv64e CPUs, Alistair Francis, 2024/02/09
- [PULL 40/61] target/riscv: Validate misa_mxl_max only once, Alistair Francis, 2024/02/09
- [PULL 42/61] target/riscv: Use RISCVException as return type for all csr ops, Alistair Francis, 2024/02/09
- [PULL 54/61] target/riscv: support new isa extension detection devicetree properties, Alistair Francis, 2024/02/09