[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 04/20] hw/cpu: Update the comments of nr_cores and nr_dies
From: |
Zhao Liu |
Subject: |
[PATCH v5 04/20] hw/cpu: Update the comments of nr_cores and nr_dies |
Date: |
Tue, 24 Oct 2023 17:03:07 +0800 |
From: Zhao Liu <zhao1.liu@intel.com>
In the nr_threads' comment, specify it represents the
number of threads in the "core" to avoid confusion.
Also add comment for nr_dies in CPUX86State.
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Babu Moger <babu.moger@amd.com>
Tested-by: Yongwei Ma <yongwei.ma@intel.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
Changes since v3:
* The new patch split out of CPUSTATE.nr_cores' fix. (Xiaoyao)
---
include/hw/core/cpu.h | 2 +-
target/i386/cpu.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
index 18593db5b20e..8197642671a9 100644
--- a/include/hw/core/cpu.h
+++ b/include/hw/core/cpu.h
@@ -408,7 +408,7 @@ struct qemu_work_item;
* See TranslationBlock::TCG CF_CLUSTER_MASK.
* @tcg_cflags: Pre-computed cflags for this cpu.
* @nr_cores: Number of cores within this CPU package.
- * @nr_threads: Number of threads within this CPU.
+ * @nr_threads: Number of threads within this CPU core.
* @running: #true if CPU is currently running (lockless).
* @has_waiter: #true if a CPU is currently waiting for the cpu_exec_end;
* valid under cpu_list_lock.
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index 471e71dbc5eb..a8f8fe3bbaf2 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -1882,6 +1882,7 @@ typedef struct CPUArchState {
TPRAccess tpr_access_type;
+ /* Number of dies within this CPU package. */
unsigned nr_dies;
} CPUX86State;
--
2.34.1
- [PATCH v5 00/20] Support smp.clusters for x86 in QEMU, Zhao Liu, 2023/10/24
- [PATCH v5 01/20] i386: Fix comment style in topology.h, Zhao Liu, 2023/10/24
- [PATCH v5 02/20] tests: Rename test-x86-cpuid.c to test-x86-topo.c, Zhao Liu, 2023/10/24
- [PATCH v5 03/20] softmmu: Fix CPUSTATE.nr_cores' calculation, Zhao Liu, 2023/10/24
- [PATCH v5 04/20] hw/cpu: Update the comments of nr_cores and nr_dies,
Zhao Liu <=
- [PATCH v5 05/20] i386/cpu: Fix i/d-cache topology to core level for Intel CPU, Zhao Liu, 2023/10/24
- [PATCH v5 06/20] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4], Zhao Liu, 2023/10/24
- [PATCH v5 07/20] i386/cpu: Consolidate the use of topo_info in cpu_x86_cpuid(), Zhao Liu, 2023/10/24
- [PATCH v5 08/20] i386: Split topology types of CPUID[0x1F] from the definitions of CPUID[0xB], Zhao Liu, 2023/10/24
- [PATCH v5 09/20] i386: Decouple CPUID[0x1F] subleaf with specific topology level, Zhao Liu, 2023/10/24
- [PATCH v5 10/20] i386: Introduce module-level cpu topology to CPUX86State, Zhao Liu, 2023/10/24
- [PATCH v5 12/20] i386: Expose module level in CPUID[0x1F], Zhao Liu, 2023/10/24
- [PATCH v5 11/20] i386: Support modules_per_die in X86CPUTopoInfo, Zhao Liu, 2023/10/24
- [PATCH v5 14/20] i386/cpu: Introduce cluster-id to X86CPU, Zhao Liu, 2023/10/24
- [PATCH v5 13/20] i386: Support module_id in X86CPUTopoIDs, Zhao Liu, 2023/10/24