[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 05/14] python/qemu: rename command() to cmd()
From: |
Eric Blake |
Subject: |
Re: [PATCH v6 05/14] python/qemu: rename command() to cmd() |
Date: |
Thu, 5 Oct 2023 13:56:33 -0500 |
User-agent: |
NeoMutt/20230517 |
On Thu, Oct 05, 2023 at 04:55:41PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Use a shorter name. We are going to move in iotests from qmp() to
> command() where possible. But command() is longer than qmp() and don't
> look better. Let's rename.
>
> You can simply grep for '\.command(' and for 'def command(' to check
> that everything is updated (command() in tests/docker/docker.py is
> unrelated).
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> docs/devel/testing.rst | 10 +-
There's a risk that this will need rebasing on top of any other test
changes being made in parallel; hopefully we can get this series in
sooner rather than later.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- Re: [PATCH v6 01/14] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument, (continued)
- [PATCH v6 08/14] iotests: add some missed checks of qmp result, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 10/14] iotests: drop some occasional semicolons, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 06/14] python/machine.py: upgrade vm.cmd() method, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 04/14] python: rename QEMUMonitorProtocol.cmd() to cmd_raw(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 05/14] python/qemu: rename command() to cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- Re: [PATCH v6 05/14] python/qemu: rename command() to cmd(),
Eric Blake <=
- [PATCH v6 13/14] tests/vm/basevm.py: use cmd() instead of qmp(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 12/14] iotests.py: pause_job(): drop return value, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 07/14] iotests: QemuStorageDaemon: add cmd() method like in QEMUMachine., Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 09/14] iotests: refactor some common qmp result checks into generic pattern, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 11/14] iotests: drop some extra ** in qmp() call, Vladimir Sementsov-Ogievskiy, 2023/10/05