[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 01/14] python/qemu/qmp/legacy: cmd(): drop cmd_id unused a
From: |
Eric Blake |
Subject: |
Re: [PATCH v6 01/14] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument |
Date: |
Thu, 5 Oct 2023 09:23:02 -0500 |
User-agent: |
NeoMutt/20230517 |
On Thu, Oct 05, 2023 at 04:55:37PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> The argument is unused, let's drop it for now, as we are going to
> refactor the interface and don't want to refactor unused things.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> python/qemu/qmp/legacy.py | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
Although I welcome John's opinion as to how long we have to maintain
legacy.py at all, given that its name implies there is a better thing
we should have converted to already.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- [PATCH v6 00/14] iotests: use vm.cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 03/14] scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 02/14] qmp_shell.py: _fill_completion() use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 01/14] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument, Vladimir Sementsov-Ogievskiy, 2023/10/05
- Re: [PATCH v6 01/14] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument,
Eric Blake <=
- [PATCH v6 08/14] iotests: add some missed checks of qmp result, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 10/14] iotests: drop some occasional semicolons, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 06/14] python/machine.py: upgrade vm.cmd() method, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 04/14] python: rename QEMUMonitorProtocol.cmd() to cmd_raw(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 05/14] python/qemu: rename command() to cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/05