Re: [PATCH 5/7] audio: do not use first -audiodev as default audio device

[BALATON Zoltan]

On Thu, 5 Oct 2023, Paolo Bonzini wrote:
> Il gio 5 ott 2023, 17:40 BALATON Zoltan <balaton@eik.bme.hu> ha scritto:
>
> > Much better, thanks. Maybe some more small clarifications as below:
> >
> > > ===================
> > > Using ``-audiodev`` to define the default audio backend (removed in 8.2)
> > > ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> > > If no audiodev property is specified, previous versions would use the
> > > first ``-audiodev`` command line option as a fallback.  Starting with
> > > version 8.2, audio backends created with ``-audiodev`` will only be
> > > used by clients (sound cards, machines with embedded sound hardware, VNC)
> >
> > machines with embedded sound hardware that can be set with the audiodev
> > machine property
>
> -M audiodev needs to be documented in the release notes, not in removed
> features.

The more places it's documented the better, peopla don't read docs anyway.

> I'm still not sure users will get it without additional explanation
> > somewhere explicitly saying that if you now get an error with -audiodev
> > driver then you may now need to use -audio driver instead (hopefully the
> > error will say that)
>
>
> Currently the error says to add audiodev=, I can change that to propose
> both.

That would help as likely the error will be the only thing the users will 
come across so if it tells them what to do that's the least annoyance.

Regards,
BALATON Zoltan