[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/47] accel: Declare AccelClass::cpu_common_[un]realize() handler
From: |
Richard Henderson |
Subject: |
[PULL 05/47] accel: Declare AccelClass::cpu_common_[un]realize() handlers |
Date: |
Tue, 3 Oct 2023 10:30:10 -0700 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Currently accel_cpu_realize() only performs target-specific
realization. Introduce the cpu_common_[un]realize fields in
the base AccelClass to be able to perform target-agnostic
[un]realization of vCPUs.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20231003123026.99229-6-philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/qemu/accel.h | 2 ++
accel/accel-common.c | 21 +++++++++++++++++++--
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/include/qemu/accel.h b/include/qemu/accel.h
index 446153b145..972a849a2b 100644
--- a/include/qemu/accel.h
+++ b/include/qemu/accel.h
@@ -43,6 +43,8 @@ typedef struct AccelClass {
bool (*has_memory)(MachineState *ms, AddressSpace *as,
hwaddr start_addr, hwaddr size);
#endif
+ bool (*cpu_common_realize)(CPUState *cpu, Error **errp);
+ void (*cpu_common_unrealize)(CPUState *cpu);
/* gdbstub related hooks */
int (*gdbstub_supported_sstep_flags)(void);
diff --git a/accel/accel-common.c b/accel/accel-common.c
index e9548eac29..11d74b4ad7 100644
--- a/accel/accel-common.c
+++ b/accel/accel-common.c
@@ -122,15 +122,32 @@ void accel_cpu_instance_init(CPUState *cpu)
bool accel_cpu_common_realize(CPUState *cpu, Error **errp)
{
CPUClass *cc = CPU_GET_CLASS(cpu);
+ AccelState *accel = current_accel();
+ AccelClass *acc = ACCEL_GET_CLASS(accel);
- if (cc->accel_cpu && cc->accel_cpu->cpu_target_realize) {
- return cc->accel_cpu->cpu_target_realize(cpu, errp);
+ /* target specific realization */
+ if (cc->accel_cpu && cc->accel_cpu->cpu_target_realize
+ && !cc->accel_cpu->cpu_target_realize(cpu, errp)) {
+ return false;
}
+
+ /* generic realization */
+ if (acc->cpu_common_realize && !acc->cpu_common_realize(cpu, errp)) {
+ return false;
+ }
+
return true;
}
void accel_cpu_common_unrealize(CPUState *cpu)
{
+ AccelState *accel = current_accel();
+ AccelClass *acc = ACCEL_GET_CLASS(accel);
+
+ /* generic unrealization */
+ if (acc->cpu_common_unrealize) {
+ acc->cpu_common_unrealize(cpu);
+ }
}
int accel_supported_gdbstub_sstep_flags(void)
--
2.34.1
- [PULL 00/47] tcg patch queue, Richard Henderson, 2023/10/03
- [PULL 01/47] accel: Rename accel_cpu_realizefn() -> accel_cpu_realize(), Richard Henderson, 2023/10/03
- [PULL 03/47] accel: Rename accel_cpu_realize() -> accel_cpu_common_realize(), Richard Henderson, 2023/10/03
- [PULL 02/47] accel: Rename AccelCPUClass::cpu_realizefn() -> cpu_target_realize(), Richard Henderson, 2023/10/03
- [PULL 04/47] accel: Introduce accel_cpu_common_unrealize() stub, Richard Henderson, 2023/10/03
- [PULL 10/47] qom: Propagate alignment through type system, Richard Henderson, 2023/10/03
- [PULL 05/47] accel: Declare AccelClass::cpu_common_[un]realize() handlers,
Richard Henderson <=
- [PULL 12/47] target/*: Add instance_align to all cpu base classes, Richard Henderson, 2023/10/03
- [PULL 06/47] accel/tcg: Have tcg_exec_realizefn() return a boolean, Richard Henderson, 2023/10/03
- [PULL 09/47] accel/tcg: Move CPUTLB definitions from cpu-defs.h, Richard Henderson, 2023/10/03
- [PULL 08/47] target/arm: Replace TARGET_PAGE_ENTRY_EXTRA, Richard Henderson, 2023/10/03
- [PULL 14/47] accel/tcg: Move CPUNegativeOffsetState into CPUState, Richard Henderson, 2023/10/03
- [PULL 20/47] accel/tcg: Remove cpu_set_cpustate_pointers, Richard Henderson, 2023/10/03
- [PULL 22/47] tcg: Remove TCGContext.tlb_fast_offset, Richard Henderson, 2023/10/03
- [PULL 26/47] accel/tcg: Modify atomic_mmu_lookup() to use CPUState, Richard Henderson, 2023/10/03
- [PULL 25/47] accel/tcg: Modify memory access functions to use CPUState, Richard Henderson, 2023/10/03
- [PULL 32/47] exec: Move cpu_loop_foo() target agnostic functions to 'cpu-common.h', Richard Henderson, 2023/10/03