[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 5/7] accel: Declare AccelClass::cpu_common_[un]realize() handl
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 5/7] accel: Declare AccelClass::cpu_common_[un]realize() handlers |
Date: |
Tue, 3 Oct 2023 14:30:23 +0200 |
Currently accel_cpu_realize() only performs target-specific
realization. Introduce the cpu_common_[un]realize fields in
the base AccelClass to be able to perform target-agnostic
[un]realization of vCPUs.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/qemu/accel.h | 2 ++
accel/accel-common.c | 21 +++++++++++++++++++--
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/include/qemu/accel.h b/include/qemu/accel.h
index 446153b145..972a849a2b 100644
--- a/include/qemu/accel.h
+++ b/include/qemu/accel.h
@@ -43,6 +43,8 @@ typedef struct AccelClass {
bool (*has_memory)(MachineState *ms, AddressSpace *as,
hwaddr start_addr, hwaddr size);
#endif
+ bool (*cpu_common_realize)(CPUState *cpu, Error **errp);
+ void (*cpu_common_unrealize)(CPUState *cpu);
/* gdbstub related hooks */
int (*gdbstub_supported_sstep_flags)(void);
diff --git a/accel/accel-common.c b/accel/accel-common.c
index e9548eac29..11d74b4ad7 100644
--- a/accel/accel-common.c
+++ b/accel/accel-common.c
@@ -122,15 +122,32 @@ void accel_cpu_instance_init(CPUState *cpu)
bool accel_cpu_common_realize(CPUState *cpu, Error **errp)
{
CPUClass *cc = CPU_GET_CLASS(cpu);
+ AccelState *accel = current_accel();
+ AccelClass *acc = ACCEL_GET_CLASS(accel);
- if (cc->accel_cpu && cc->accel_cpu->cpu_target_realize) {
- return cc->accel_cpu->cpu_target_realize(cpu, errp);
+ /* target specific realization */
+ if (cc->accel_cpu && cc->accel_cpu->cpu_target_realize
+ && !cc->accel_cpu->cpu_target_realize(cpu, errp)) {
+ return false;
}
+
+ /* generic realization */
+ if (acc->cpu_common_realize && !acc->cpu_common_realize(cpu, errp)) {
+ return false;
+ }
+
return true;
}
void accel_cpu_common_unrealize(CPUState *cpu)
{
+ AccelState *accel = current_accel();
+ AccelClass *acc = ACCEL_GET_CLASS(accel);
+
+ /* generic unrealization */
+ if (acc->cpu_common_unrealize) {
+ acc->cpu_common_unrealize(cpu);
+ }
}
int accel_supported_gdbstub_sstep_flags(void)
--
2.41.0
- [PATCH v2 0/7] accel: Restrict tcg_exec_[un]realizefn() to TCG, Philippe Mathieu-Daudé, 2023/10/03
- [PATCH v2 1/7] accel: Rename accel_cpu_realizefn() -> accel_cpu_realize(), Philippe Mathieu-Daudé, 2023/10/03
- [PATCH v2 2/7] accel: Rename AccelCPUClass::cpu_realizefn() -> cpu_target_realize(), Philippe Mathieu-Daudé, 2023/10/03
- [PATCH v2 4/7] accel: Introduce accel_cpu_common_unrealize() stub, Philippe Mathieu-Daudé, 2023/10/03
- [PATCH v2 3/7] accel: Rename accel_cpu_realize() -> accel_cpu_common_realize(), Philippe Mathieu-Daudé, 2023/10/03
- [PATCH v2 6/7] accel/tcg: Have tcg_exec_realizefn() return a boolean, Philippe Mathieu-Daudé, 2023/10/03
- [PATCH v2 5/7] accel: Declare AccelClass::cpu_common_[un]realize() handlers,
Philippe Mathieu-Daudé <=
- [PATCH v2 7/7] accel/tcg: Restrict tcg_exec_[un]realizefn() to TCG, Philippe Mathieu-Daudé, 2023/10/03
- Re: [PATCH v2 0/7] accel: Restrict tcg_exec_[un]realizefn() to TCG, Claudio Fontana, 2023/10/03
- Re: [PATCH v2 0/7] accel: Restrict tcg_exec_[un]realizefn() to TCG, Richard Henderson, 2023/10/03