[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/26] block: add missing coroutine_fn annotations
From: |
Alberto Campinho Faria |
Subject: |
Re: [PATCH 02/26] block: add missing coroutine_fn annotations |
Date: |
Thu, 22 Sep 2022 16:11:45 +0100 |
On Thu, Sep 22, 2022 at 9:49 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
> Callers of coroutine_fn must be coroutine_fn themselves, or the call
> must be within "if (qemu_in_coroutine())". Apply coroutine_fn to
> functions where this holds.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block.c | 6 +++---
> block/block-backend.c | 10 +++++-----
> block/io.c | 22 +++++++++++-----------
> 3 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/block.c b/block.c
> index bc85f46eed..5c34ada53f 100644
> --- a/block.c
> +++ b/block.c
> @@ -631,9 +631,9 @@ static int64_t create_file_fallback_truncate(BlockBackend
> *blk,
> * Helper function for bdrv_create_file_fallback(): Zero the first
> * sector to remove any potentially pre-existing image header.
> */
> -static int create_file_fallback_zero_first_sector(BlockBackend *blk,
> - int64_t current_size,
> - Error **errp)
> +static int coroutine_fn create_file_fallback_zero_first_sector(BlockBackend
> *blk,
> + int64_t
> current_size,
> + Error **errp)
Why mark this coroutine_fn? Maybe the intention was to also replace
the call to blk_pwrite_zeroes() with blk_co_pwrite_zeroes()?
Regardless:
Reviewed-by: Alberto Faria <afaria@redhat.com>
- [PATCH v3 00/26] block: fix coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 05/26] coroutine: remove incorrect coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 09/26] iscsi: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 01/26] block/nvme: separate nvme_get_free_req cases for coroutine/non-coroutine context, Paolo Bonzini, 2022/09/22
- [PATCH 02/26] block: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- Re: [PATCH 02/26] block: add missing coroutine_fn annotations,
Alberto Campinho Faria <=
- [PATCH 06/26] blkdebug: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 04/26] nbd: remove incorrect coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 08/26] file-posix: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 15/26] copy-before-write: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 11/26] nfs: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 07/26] blkverify: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 26/26] test-coroutine: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 16/26] curl: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 03/26] qcow2: remove incorrect coroutine_fn annotations, Paolo Bonzini, 2022/09/22