[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 15/26] copy-before-write: add missing coroutine_fn annotations
From: |
Paolo Bonzini |
Subject: |
[PATCH 15/26] copy-before-write: add missing coroutine_fn annotations |
Date: |
Thu, 22 Sep 2022 10:49:13 +0200 |
Callers of coroutine_fn must be coroutine_fn themselves, or the call
must be within "if (qemu_in_coroutine())". Apply coroutine_fn to
functions where this holds.
Reviewed-by: Alberto Faria <afaria@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/copy-before-write.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
index c24b8dd117..14af7eb753 100644
--- a/block/copy-before-write.c
+++ b/block/copy-before-write.c
@@ -203,9 +203,9 @@ static int coroutine_fn cbw_co_flush(BlockDriverState *bs)
* It's guaranteed that guest writes will not interact in the region until
* cbw_snapshot_read_unlock() called.
*/
-static BlockReq *cbw_snapshot_read_lock(BlockDriverState *bs,
- int64_t offset, int64_t bytes,
- int64_t *pnum, BdrvChild **file)
+static coroutine_fn BlockReq *cbw_snapshot_read_lock(BlockDriverState *bs,
+ int64_t offset, int64_t
bytes,
+ int64_t *pnum, BdrvChild
**file)
{
BDRVCopyBeforeWriteState *s = bs->opaque;
BlockReq *req = g_new(BlockReq, 1);
@@ -240,7 +240,7 @@ static BlockReq *cbw_snapshot_read_lock(BlockDriverState
*bs,
return req;
}
-static void cbw_snapshot_read_unlock(BlockDriverState *bs, BlockReq *req)
+static coroutine_fn void cbw_snapshot_read_unlock(BlockDriverState *bs,
BlockReq *req)
{
BDRVCopyBeforeWriteState *s = bs->opaque;
--
2.37.3
- [PATCH v3 00/26] block: fix coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 05/26] coroutine: remove incorrect coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 09/26] iscsi: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 01/26] block/nvme: separate nvme_get_free_req cases for coroutine/non-coroutine context, Paolo Bonzini, 2022/09/22
- [PATCH 02/26] block: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 06/26] blkdebug: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 04/26] nbd: remove incorrect coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 08/26] file-posix: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 15/26] copy-before-write: add missing coroutine_fn annotations,
Paolo Bonzini <=
- [PATCH 11/26] nfs: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 07/26] blkverify: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 26/26] test-coroutine: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 16/26] curl: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 03/26] qcow2: remove incorrect coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 13/26] parallels: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 14/26] qcow2: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 18/26] quorum: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 12/26] nvme: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22
- [PATCH 10/26] nbd: add missing coroutine_fn annotations, Paolo Bonzini, 2022/09/22