[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 10/26] nbd: add missing coroutine_fn annotations
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 10/26] nbd: add missing coroutine_fn annotations |
Date: |
Wed, 18 May 2022 09:50:26 -0500 |
User-agent: |
NeoMutt/20220429-71-6f7d3e |
On Mon, May 09, 2022 at 12:30:03PM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/nbd.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/block/nbd.c b/block/nbd.c
> index 6085ab1d2c..fe913a6db4 100644
> --- a/block/nbd.c
> +++ b/block/nbd.c
> @@ -983,11 +983,11 @@ static void nbd_iter_request_error(NBDReplyChunkIter
> *iter, int ret)
> * nbd_reply_chunk_iter_receive
> * The pointer stored in @payload requires g_free() to free it.
> */
> -static bool nbd_reply_chunk_iter_receive(BDRVNBDState *s,
> - NBDReplyChunkIter *iter,
> - uint64_t handle,
> - QEMUIOVector *qiov, NBDReply *reply,
> - void **payload)
> +static bool coroutine_fn nbd_reply_chunk_iter_receive(BDRVNBDState *s,
> + NBDReplyChunkIter
> *iter,
> + uint64_t handle,
> + QEMUIOVector *qiov,
> NBDReply *reply,
Might be worth wrapping the now-longer line.
> + void **payload)
Used only by the macro NBD_FOREACH_REPLY_CHUNK(), which in turn is
used by nbd_co_receive_return_code, nbd_co_receive_cmdread_reply,
nbd_co_receive_blockstatus_reply, which all got recently marked in
0c43c6fc.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v2 04/26] coroutine: remove incorrect coroutine_fn annotations, (continued)
[PATCH v2 08/26] file-posix: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 10/26] nbd: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
- Re: [PATCH v2 10/26] nbd: add missing coroutine_fn annotations,
Eric Blake <=
[PATCH v2 11/26] nfs: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 09/26] iscsi: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 12/26] nvme: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 13/26] parallels: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 14/26] qcow2: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 15/26] copy-before-write: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 17/26] qed: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 18/26] quorum: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 23/26] raw-format: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09