qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 07/26] block: add missing coroutine_fn annotations


From: Alberto Faria
Subject: Re: [PATCH v2 07/26] block: add missing coroutine_fn annotations
Date: Mon, 16 May 2022 19:49:25 +0100

On Sat, May 14, 2022 at 10:54 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
> But I agree that blk_pwrite_zeros shouldn't be a coroutine_fn, because
> of fuse_fallocate and block_load.  Alberto, this function is another
> candidate for adding a blk_co_pwrite_zeros + a matching
> generated_co_wrapper.

Thanks for the heads up. In fact, looking at block-backend-io.h,
there's quite a few functions that (AFAICT) we could implement using
generated_co_wrapper:

    - blk_pread, blk_preadv, blk_preadv_part
    - blk_pwrite, blk_pwritev, blk_pwritev_part
    - blk_pwrite_compressed, blk_pwrite_zeroes
    - blk_pdiscard
    - blk_flush
    - blk_truncate, blk_ioctl

Would this make sense?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]