[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/26] block: add missing coroutine_fn annotations
From: |
Alberto Faria |
Subject: |
Re: [PATCH v2 07/26] block: add missing coroutine_fn annotations |
Date: |
Mon, 16 May 2022 19:49:25 +0100 |
On Sat, May 14, 2022 at 10:54 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
> But I agree that blk_pwrite_zeros shouldn't be a coroutine_fn, because
> of fuse_fallocate and block_load. Alberto, this function is another
> candidate for adding a blk_co_pwrite_zeros + a matching
> generated_co_wrapper.
Thanks for the heads up. In fact, looking at block-backend-io.h,
there's quite a few functions that (AFAICT) we could implement using
generated_co_wrapper:
- blk_pread, blk_preadv, blk_preadv_part
- blk_pwrite, blk_pwritev, blk_pwritev_part
- blk_pwrite_compressed, blk_pwrite_zeroes
- blk_pdiscard
- blk_flush
- blk_truncate, blk_ioctl
Would this make sense?
- Re: [PATCH v2 01/26] block: remove incorrect coroutine_fn annotations, (continued)
[PATCH v2 08/26] file-posix: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 10/26] nbd: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 11/26] nfs: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 09/26] iscsi: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 12/26] nvme: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
[PATCH v2 13/26] parallels: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09