[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't al
From: |
Peter Maydell |
Subject: |
Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure |
Date: |
Wed, 15 Sep 2021 13:12:23 +0100 |
On Wed, 15 Sept 2021 at 09:29, Daniel P. Berrangé <berrange@redhat.com> wrote:
> Urgh, my bad, I completely forget this behaviour when reviewing.
> When we only have
>
> when: manual
>
> then the job has to be manually started, and it still contributes
> to pipeline status, so it /must/ triggered manually.
>
> If we want it to be manually started and not contribute to the
> pipeline status we need:
>
> rules:
> ...
> when: manual
> allow_failure: true
So there's no way to say "if it is triggered, then it must
not fail, but if it is not triggered, that's OK" ?
I guess it's not a big deal either way though.
So the fix is to add back the allow_failure tag to those jobs
which are manual. I'll send a patch...
-- PMM
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, (continued)
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Daniel P . Berrangé, 2021/09/13
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Willian Rampazzo, 2021/09/13
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Thomas Huth, 2021/09/14
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Peter Maydell, 2021/09/14
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Peter Maydell, 2021/09/14
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Willian Rampazzo, 2021/09/14
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Daniel P . Berrangé, 2021/09/15
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Philippe Mathieu-Daudé, 2021/09/15
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure,
Peter Maydell <=
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Daniel P . Berrangé, 2021/09/15
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Peter Maydell, 2021/09/15