[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't al
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure |
Date: |
Wed, 15 Sep 2021 09:29:08 +0100 |
User-agent: |
Mutt/2.0.7 (2021-05-04) |
On Tue, Sep 14, 2021 at 08:17:19PM +0100, Peter Maydell wrote:
> On Mon, 13 Sept 2021 at 11:19, Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > Currently we define a lot of jobs for our custom runners:
> > for both aarch64 and s390x we have
> > - all-linux-static
> > - all
> > - alldbg
> > - clang (manual)
> > - tci
> > - notcg (manual)
> >
> > This is overkill. The main reason to run on these hosts is to get
> > coverage for the host architecture; we can leave the handling of
> > differences like debug vs non-debug to the x86 CI jobs.
> >
> > The jobs are also generally running OK; they occasionally fail due to
> > timeouts, which is likely because we're overloading the machine by
> > asking it to run 4 CI jobs at once plus the ad-hoc CI.
> >
> > Remove the 'allow_failure' tag from all these jobs, and switch the
> > s390x-alldbg, aarch64-all, s390x-tci and aarch64-tci jobs to manual.
> > This will let us make the switch for s390x and aarch64 hosts from
> > the ad-hoc CI to gitlab.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> It looks like this change has resulted in pipelines ending
> up in a "blocked" state:
>
> https://gitlab.com/qemu-project/qemu/-/pipelines
>
> I'm not sure why this is -- is it perhaps because there were
> other jobs that depended on the now-manual-only jobs ?
> Can somebody suggest a fix ?
Urgh, my bad, I completely forget this behaviour when reviewing.
When we only have
when: manual
then the job has to be manually started, and it still contributes
to pipeline status, so it /must/ triggered manually.
If we want it to be manually started and not contribute to the
pipeline status we need:
rules:
...
when: manual
allow_failure: true
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Peter Maydell, 2021/09/13
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Daniel P . Berrangé, 2021/09/13
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Willian Rampazzo, 2021/09/13
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Thomas Huth, 2021/09/14
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Peter Maydell, 2021/09/14
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Peter Maydell, 2021/09/14
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Willian Rampazzo, 2021/09/14
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure,
Daniel P . Berrangé <=
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Philippe Mathieu-Daudé, 2021/09/15
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Peter Maydell, 2021/09/15
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Daniel P . Berrangé, 2021/09/15
- Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure, Peter Maydell, 2021/09/15