Re: [Qemu-devel] [PATCH v4 0/3] tests: Reorganize MIPS TCG directories and files

[Philippe Mathieu-Daudé]

Hi Aleksandar Rikalo,

On 1/24/19 4:37 PM, Aleksandar Rikalo wrote:
>> From: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
>> Sent: Thursday, January 24, 2019 4:19 PM
>> To: qemu-devel@nongnu.org
>> Cc: aurelien@aurel32.net; Aleksandar Markovic; Aleksandar Rikalo
>> Subject: [PATCH v4 0/3] tests: Reorganize MIPS TCG directories and files
>>
>> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>>
>> Reorganize MIPS TCG directories and files.
>>
>> Directories for DSP tests in system mode are deleted. They
>> introduce more complexity in test structure compared to the
>> value they add. Still, these tests may be moved somewhere
>> else, let's say in a new acceptance test that will boot
>> "mips64r2" virtual machine.
>>
>> All remaining test will are user mode tests, which will
>> simplify maintenance of mips tcg tests overall.
>>
>> The file movement is done using "git mv" command, so "git
>> blame" will still display the original information, regardless
>> of the new names and locations of involved files. Also, the
>> command "git config diff.renames true" was used to keep the
>> size of movement patches reasonable.
>>
>> v3->v4:
>>   - DSP ASE system mode tests given up
>>   - Makefiles provided for tests that remain
>>
>> v2->v3:
>>   - corrected missing "v2" that caused wrong message linking
>>     (the version is now "v3", of course)
>>
>> v1->v2:
>>   - used "git config diff.renames true" before sending
>>   - rebased to the latest code (included newly added r5900 tests)
>>
>>
>> Aleksandar Markovic (3):
>>   tests: tcg: mips: Move source files to new locations
>>   tests: tcg: mips: Add two new Makefiles
>>   tests: tcg: mips: Remove old directories
> 
> I too think that this will simplify the test dirs structure and
> maintenance. I cannot wait to see these directories populated with
> new tests for various MIPS ISAs and ASEs.
> 
> For all patches in this series:
> 
> Reviewed-by: Aleksandar Rikalo <arikalo@wavecomp.com>

Apparently this series was a bit too enthusiastic and removed
many tests (MIPS64 DSP r1 and r2 for example) which then got
never reintroduced. What is your plan regarding the "new
tests" you mentioned?

Thanks,

Phil.